Re: [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-10-16 at 09:50 +0100, Wei Liu wrote:
> On Fri, Oct 16, 2015 at 09:48:34AM +0100, Ian Campbell wrote:
> > On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote:
> > > Fix the types used to store the memory parameters of an HVM guest,
> > > previously they defaulted to unsigned long on 32bit toolstack builds,
> > > which
> > > is wrong because a 32bit value cannot hold a 64bit memory address
> > > that
> > > crosses the 4GB boundary.
> > > 
> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Wei Liu <wei.liu2@citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Thanks.

> > > ---
> > > I don't have a 32bit Dom0 at hand, so if someone can try to create a
> > > HVM
> > > guests using a 32bit toolstack with more than 4GB of RAM it would be
> > > helpful.
> > 
> > I am happy after eyeballing that this is at least an improvement and am
> > content to let osstest answer this question.
> > 
> 
> Agreed.

Done.

> > I'm still having some trouble accessing the machines where I typically do
> > all my semi-automated pre-push build tests but given that these issues have
> > been blocking the push gate for a while now I am going to push this change
> > without the full, i.e. just a quick local adhoc build which I am doing now.

Roger, please keep an eye out for build issues in the smoke test etc.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel