From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] tools: libxl: CODING_STYLE: GC* cannot be
	used with NOGC
Date: Fri, 16 Oct 2015 12:14:05 +0100
Message-ID: <1444994045.12442.69.camel@citrix.com>
References: <1444991592-3166-1-git-send-email-ian.campbell@citrix.com>
	<20151016103956.GM32638@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20151016103956.GM32638@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote:
> On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote:
> > GC* assume an existing gc in scope, which means they can't be passed
> > NOGC. Instead recommend the use of the underlying functions with NOGC,
> > noting that this is excepitonal.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > ---
> >  tools/libxl/CODING_STYLE | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/libxl/CODING_STYLE b/tools/libxl/CODING_STYLE
> > index a65efb3..545dc77 100644
> > --- a/tools/libxl/CODING_STYLE
> > +++ b/tools/libxl/CODING_STYLE
> > @@ -57,13 +57,14 @@ whenever they are applicable.  For example:
> >    libxl__log[v]           LOG, LOGE, LOGEV
> >    libxl__sprintf          GCSPRINTF
> >    libxl__*alloc et al.    GCNEW, GCNEW_ARRAY, GCREALLOC_ARRAY
> > -  malloc et al.           GCNEW, GCNEW_ARRAY, GCREALLOC_ARRAY with
> > NOGC
> >    isalnum etc. directly   CTYPE
> >    libxl__ctx_[un]lock     CTX_LOCK, CTX_UNLOCK
> >    gc=...; ao=...;         EGC_GC, AO_GC, STATE_AO_GC
> >    explicit gc creation    GC_INIT, GC_FREE
> >    memset(..,0,sizeof..)   FILLZERO
> >  
> > +Instead of malloc et al one should (as an exception to the above) use
> > +libxl__{zalloc,alloc,realloc} etc but passing NOGC.
> >  
> 
> There is no libxl__alloc. DYM libxl__malloc?

I meant libxl__calloc.

Ian.