From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ed Bartosh <ed.bartosh@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 4/4] toaster: Add tests for error message display on the build dashboard
Date: Fri, 16 Oct 2015 14:17:47 +0100 [thread overview]
Message-ID: <1445001467.17974.18.camel@linuxfoundation.org> (raw)
In-Reply-To: <355ebfff2a5145d117aa8122cb7efdf6917eeeeb.1444910218.git.ed.bartosh@linux.intel.com>
On Thu, 2015-10-15 at 15:45 +0300, Ed Bartosh wrote:
> From: Elliot Smith <elliot.smith@intel.com>
>
> Add tests to ensure that log messages with CRITICAL level and
> with EXCEPTION level are shown in the main errors display
> on the build dashboard.
>
> [YOCTO #8320]
>
> Signed-off-by: Elliot Smith <elliot.smith@intel.com>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> lib/toaster/toastergui/tests.py | 91 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 89 insertions(+), 2 deletions(-)
>
> diff --git a/lib/toaster/toastergui/tests.py b/lib/toaster/toastergui/tests.py
> index 7c4bd39..29dd7fd 100644
> --- a/lib/toaster/toastergui/tests.py
> +++ b/lib/toaster/toastergui/tests.py
> @@ -26,15 +26,15 @@ from django.test.client import RequestFactory
> from django.core.urlresolvers import reverse
> from django.utils import timezone
>
> -from orm.models import Project, Release, BitbakeVersion, Package
> +from orm.models import Project, Release, BitbakeVersion, Package, LogMessage
> from orm.models import ReleaseLayerSourcePriority, LayerSource, Layer, Build
> from orm.models import Layer_Version, Recipe, Machine, ProjectLayer, Target
> from orm.models import CustomImageRecipe, ProjectVariable
> from orm.models import Branch
>
> from toastergui.tables import SoftwareRecipesTable
> -from bs4 import BeautifulSoup
> import json
> +from bs4 import BeautifulSoup
> import re
Sadly this failed to apply to master, please send a version which
does...
Cheers,
Richard
prev parent reply other threads:[~2015-10-16 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 12:45 [PATCH 0/4] toaster: Improve display of errors and Toaster exceptions Ed Bartosh
2015-10-15 12:45 ` [PATCH 1/4] toaster: Record critical errors Ed Bartosh
2015-10-15 12:45 ` [PATCH 2/4] toaster: Remove Toaster exceptions section of build dashboard Ed Bartosh
2015-10-15 12:45 ` [PATCH 3/4] toaster: Guard against builds with no targets Ed Bartosh
2015-10-15 12:45 ` [PATCH 4/4] toaster: Add tests for error message display on the build dashboard Ed Bartosh
2015-10-16 13:17 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445001467.17974.18.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=ed.bartosh@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.