All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aybuke Ozdemir <aybuke.147@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: Aybuke Ozdemir <aybuke.147@gmail.com>
Subject: [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level
Date: Sat, 17 Oct 2015 01:04:32 +0300	[thread overview]
Message-ID: <1445033073-10154-1-git-send-email-aybuke.147@gmail.com> (raw)

Problem found using checkpatch.pl:
"WARNING: printk() should include KERN_ facility level"

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
Changes since v1:
* used dev_info instead of pr_info.
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..d20cd92 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		dev_info("found sm750le\n");
 }
 
 
-- 
1.9.1



             reply	other threads:[~2015-10-16 22:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 22:04 Aybuke Ozdemir [this message]
2015-10-16 22:04 ` [PATCH v2 2/2] Staging: sm750fb: Remove multiple blank lines Aybuke Ozdemir
2015-10-17  5:06 ` [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level Greg KH
2015-10-17 10:33   ` Aybuke Ozdemir
2015-10-17 10:43     ` Ksenija Stanojević
2015-10-17 10:44     ` Julia Lawall
2015-10-17 11:14       ` Aybuke Ozdemir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445033073-10154-1-git-send-email-aybuke.147@gmail.com \
    --to=aybuke.147@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.