From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbbJQWEn (ORCPT ); Sat, 17 Oct 2015 18:04:43 -0400 Subject: Patch "extcon: Fix attached value returned by is_extcon_changed" has been added to the 4.2-stable tree To: hdegoede@redhat.com, cw00.choi@samsung.com, gregkh@linuxfoundation.org Cc: , From: Date: Sat, 17 Oct 2015 15:04:41 -0700 Message-ID: <1445119481152161@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled extcon: Fix attached value returned by is_extcon_changed to the 4.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: extcon-fix-attached-value-returned-by-is_extcon_changed.patch and it can be found in the queue-4.2 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From f4513b065f7dbd37224226ef6e44b09eff742776 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Mon, 24 Aug 2015 00:35:36 +0200 Subject: extcon: Fix attached value returned by is_extcon_changed From: Hans de Goede commit f4513b065f7dbd37224226ef6e44b09eff742776 upstream. is_extcon_changed should only check the idx-th bit of new, not the entirety of new when setting attached. This fixes extcon sending notifications that a cable was inserted when it gets removed while another cable is still connected. Signed-off-by: Hans de Goede Signed-off-by: Chanwoo Choi Signed-off-by: Greg Kroah-Hartman --- drivers/extcon/extcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -159,7 +159,7 @@ static int find_cable_index_by_name(stru static bool is_extcon_changed(u32 prev, u32 new, int idx, bool *attached) { if (((prev >> idx) & 0x1) != ((new >> idx) & 0x1)) { - *attached = new ? true : false; + *attached = ((new >> idx) & 0x1) ? true : false; return true; } Patches currently in stable-queue which might be from hdegoede@redhat.com are queue-4.2/extcon-fix-attached-value-returned-by-is_extcon_changed.patch