All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.
Date: Mon, 19 Oct 2015 15:29:03 +0200	[thread overview]
Message-ID: <1445261343.13733.41.camel@redhat.com> (raw)
In-Reply-To: <20151019115234.GA5874@morn.lan>

  Hi

> > Windows fails to compile:
> > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
> > ‘fw_cfg_dma_mem_read’:
> > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
> > integer constant is too large for ‘long’ type
> 
> I don't have a Windows test environment, but I suspect the following:

Builds fine here for some strange reason ...

> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */
> 
> should be changed to:
> 
> #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */

But that is correct.  Fixed.

cheers,
  Gerd

  parent reply	other threads:[~2015-10-19 13:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  9:17 [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline Gerd Hoffmann
2015-10-19  9:17 ` [Qemu-devel] [PULL 1/7] fw_cfg: insert string blobs via qemu cmdline Gerd Hoffmann
2015-10-19  9:17 ` [Qemu-devel] [PULL 2/7] fw_cfg: document fw_cfg_modify_iXX() update functions Gerd Hoffmann
2015-10-19  9:18 ` [Qemu-devel] [PULL 3/7] fw_cfg DMA interface documentation Gerd Hoffmann
2015-10-19  9:18 ` [Qemu-devel] [PULL 4/7] Implement fw_cfg DMA interface Gerd Hoffmann
2015-10-19  9:18 ` [Qemu-devel] [PULL 5/7] Enable fw_cfg DMA interface for ARM Gerd Hoffmann
2015-10-19  9:18 ` [Qemu-devel] [PULL 6/7] Enable fw_cfg DMA interface for x86 Gerd Hoffmann
2015-10-19  9:18 ` [Qemu-devel] [PULL 7/7] fw_cfg: Define a static signature to be returned on DMA port reads Gerd Hoffmann
2015-10-19 11:12 ` [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline Peter Maydell
2015-10-19 11:52   ` Kevin O'Connor
2015-10-19 12:02     ` Peter Maydell
2015-10-19 12:12       ` Kevin O'Connor
2015-10-19 12:22         ` Marc Marí
2015-10-19 13:31           ` Gerd Hoffmann
2015-10-19 13:29     ` Gerd Hoffmann [this message]
2015-10-19 13:55       ` Peter Maydell
2015-10-19 15:17   ` Laszlo Ersek
2015-10-19 15:37     ` Marc Marí

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445261343.13733.41.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.