RE: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties

[CK Hu <ck.hu@mediatek.com>]

Hi, Philipp:

> -----Original Message-----
> From: Philipp Zabel [mailto:p.zabel@pengutronix.de]
> Sent: Friday, October 16, 2015 9:09 PM
> Subject: Re: [RFC 1/2] Dcumentation: bridge: Add documentation for
ps8640
> DT properties
> 
> Hi CK,
> 
> there is a typo in the subject: s/Dcumentation/Documentation/.

We will correct next patch.

> 
> Am Freitag, den 16.10.2015, 20:15 +0800 schrieb CK Hu:
> > From: Jitao Shi <jitao.shi@mediatek.com>
> >
> > Add documentation for DT properties supported by ps8640 DSI-eDP
> > converter.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> [...]
> > +	- ps8640-1v2-supply: OF device-tree regulator specification for
1v2.
> > +	- ps8640-3v3-supply: OF device-tree regulator specification for
3v3.
> 
> The ps8640- part of the regulator supply property names is redundant.
> The PS8622 driver uses vdd12-supply as its regulator. Should we strive
for
> consistency here? Or if you have access to the datasheet, how are
these inputs
> called there?

yes, we should use vdd12-supply and vdd33-supply, we'll fixed it in next
patch.

> 
> > +
> > +Optional properties:
> > +	- video interfaces: Device node can contain video interface port
> > +			    nodes for panel according to [1].
> > +
> > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> 
> It should be documented here that port@0 is the input port and port@1
is the
> output port.

Yes, port@0 is the input port and port@1 is the output port. We'll add
the info in next patch.

> 
> best regards
> Philipp