From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH] ms-queuedaemon: Do not spin if client input is delayed/truncated
Date: Wed, 21 Oct 2015 09:53:39 +0100 [thread overview]
Message-ID: <1445417619.9563.46.camel@citrix.com> (raw)
In-Reply-To: <1445362001-32521-1-git-send-email-ian.jackson@eu.citrix.com>
On Tue, 2015-10-20 at 18:26 +0100, Ian Jackson wrote:
> chan-read-data would spin if `read' returns early because of
> nonblocking mode.
>
> Check whether the return value is the empty string (which can only
> happen on eof or nonblocking lack of data, and we checked eof just
> before), and if so, simply return. The fileevent remains set up so we
> will be called again when more data arrives.
>
> (Deployment/testing note: this change is currently live in Cambridge,
> as I cowboyed it directly into ~osstest/daemons-testing.git, on
> observing this misbehaviour.)
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
prev parent reply other threads:[~2015-10-21 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 17:26 [OSSTEST PATCH] ms-queuedaemon: Do not spin if client input is delayed/truncated Ian Jackson
2015-10-21 8:53 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445417619.9563.46.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.