From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/xenpaging: install directory with default permission Date: Wed, 21 Oct 2015 14:46:54 +0100 Message-ID: <1445435214.9563.150.camel@citrix.com> References: <1445429422-18749-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zotjo-0001j6-Us for xen-devel@lists.xenproject.org; Wed, 21 Oct 2015 13:47:33 +0000 In-Reply-To: <1445429422-18749-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, 2015-10-21 at 13:10 +0100, Wei Liu wrote: > There is no need to explicitly ask for 700. Is the rationale for 0700 explicitly not that the files in here will contain possibly sensitive date from guest memory? i.e. the use of something other than the default is deliberate. If you think that is wrong then I think the changelog should explain why. > Signed-off-by: Wei Liu > --- > tools/xenpaging/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile > index 2407a30..4badaae 100644 > --- a/tools/xenpaging/Makefile > +++ b/tools/xenpaging/Makefile > @@ -24,7 +24,7 @@ xenpaging: $(OBJS) > $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS) > > install: all > - $(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR) > + $(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR) > $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) > $(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN) >