From: Punit Vara <punitvara@gmail.com>
To: kvalo@qca.qualcomm.com
Cc: stas.yakovlev@gmail.com, chaoming_li@realsil.com.cn,
Larry.Finger@lwfinger.net, chunkeey@googlemail.com,
sgruszka@redhat.com, brudley@broadcom.com, arend@broadcom.com,
linville@tuxdriver.com, jirislaby@gmail.com, mickflemm@gmail.com,
mcgrof@do-not-panic.com, k.eugene.e@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211-dev-list@broadcom.com, wcn36xx@lists.infradead.org,
johannes.berg@intel.com, meuleman@broadcom.com,
Punit Vara <punitvara@gmail.com>
Subject: [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret
Date: Wed, 21 Oct 2015 20:25:33 +0530 [thread overview]
Message-ID: <1445439337-19055-12-git-send-email-punitvara@gmail.com> (raw)
In-Reply-To: <1445439337-19055-1-git-send-email-punitvara@gmail.com>
This patch is to the 3945-mac.c file that fixes up following warning
by coccicheck:
drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable:
"ret". Return "- EOPNOTSUPP" on line 249
Return -EOPNOTSUPP directly instead of return using ret
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/net/wireless/iwlegacy/3945-mac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index af1b3e6..ff4dc44 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -244,9 +244,7 @@ il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf,
static int
il3945_remove_static_key(struct il_priv *il)
{
- int ret = -EOPNOTSUPP;
-
- return ret;
+ return -EOPNOTSUPP;
}
static int
@@ -529,7 +527,6 @@ il3945_tx_skb(struct il_priv *il,
if (unlikely(tid >= MAX_TID_COUNT))
goto drop;
}
-
/* Descriptor for chosen Tx queue */
txq = &il->txq[txq_id];
q = &txq->q;
--
2.5.3
next prev parent reply other threads:[~2015-10-21 14:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 14:55 [PATCH 00/15] Fix warnings reported by coccicheck Punit Vara
2015-10-21 14:55 ` [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks Punit Vara
2015-10-21 14:58 ` Jiri Slaby
2015-10-21 21:43 ` Sergei Shtylyov
2015-10-22 18:22 ` punit vara
2015-10-21 14:55 ` [PATCH 02/15] net: wireless: ath: Remove unnecessary semicolon Punit Vara
2015-10-21 14:55 ` [PATCH 03/15] " Punit Vara
2015-10-21 14:55 ` [PATCH 04/15] net: wireless: ipw2x00: use | instead of + for summing bitmasks Punit Vara
2015-10-21 14:55 ` [PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Punit Vara
2015-10-21 15:40 ` kbuild test robot
2015-10-21 14:55 ` [PATCH 06/15] net: wireless: rtwifi: Remove duplicated arguments to | Punit Vara
2015-10-21 14:55 ` [PATCH 07/15] net: wireless: brcm80211: " Punit Vara
2015-10-21 14:55 ` [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg Punit Vara
2015-10-21 15:00 ` Jiri Slaby
2015-10-21 18:05 ` punit vara
2015-10-21 14:55 ` [PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16 Punit Vara
2015-10-21 14:55 ` [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Punit Vara
2015-10-21 14:55 ` Punit Vara [this message]
2015-10-21 21:45 ` [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret Sergei Shtylyov
2015-10-21 14:55 ` [PATCH 12/15] net: wireless: brcm80211: Remove unneeded variable which return 0 Punit Vara
2015-10-21 14:55 ` [PATCH 13/15] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Punit Vara
2015-10-21 14:55 ` [PATCH 14/15] net: wireless: ath: Remove unneeded variable ret " Punit Vara
2015-10-21 14:55 ` [PATCH 15/15] " Punit Vara
2015-10-21 21:46 ` Sergei Shtylyov
2015-10-22 18:23 ` punit vara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445439337-19055-12-git-send-email-punitvara@gmail.com \
--to=punitvara@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=chaoming_li@realsil.com.cn \
--cc=chunkeey@googlemail.com \
--cc=jirislaby@gmail.com \
--cc=johannes.berg@intel.com \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@do-not-panic.com \
--cc=meuleman@broadcom.com \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=stas.yakovlev@gmail.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.