From mboxrd@z Thu Jan 1 00:00:00 1970 From: mlin@kernel.org (Ming Lin) Date: Wed, 21 Oct 2015 08:01:19 -0700 Subject: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} In-Reply-To: References: <1439363241-31772-1-git-send-email-mlin@kernel.org> <1439363241-31772-6-git-send-email-mlin@kernel.org> <20151013115011.GA6546@infradead.org> <20151021072126.GA7671@infradead.org> Message-ID: <1445439679.3126.5.camel@hasee> On Wed, 2015-10-21@09:39 -0400, Jeff Moyer wrote: > Christoph Hellwig writes: > > > Jens, Ming: > > > > are you fine with the one liner change to get back to the old I/O > > pattern? While it looks like the cards fault I'd like to avoid this > > annoying regression. > > I'm not Jens or Ming, but your patch looks fine to me, though you'll > want to remove the MAX_BIO_SECTORS definition since it's now unused. > It's not clear to me why the limit was lowered in the first place. UINT_MAX >> 9 is not power of 2 and it causes dm-thinp discard fails. At the lengthy discussion: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios We agreed to cap discard to 2G as an interim solution for 4.3 until the dm-thinp discard code is rewritten. Hi Mike, Will the dm-thinp discard rewritten ready for 4.4? Thanks, Ming > > You can add my Reviewed-by: Jeff Moyer if you resend > the patch. > > -Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755546AbbJUPBc (ORCPT ); Wed, 21 Oct 2015 11:01:32 -0400 Received: from mail.kernel.org ([198.145.29.136]:57860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751875AbbJUPB0 (ORCPT ); Wed, 21 Oct 2015 11:01:26 -0400 Message-ID: <1445439679.3126.5.camel@hasee> Subject: Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} From: Ming Lin To: Jeff Moyer Cc: Christoph Hellwig , lkml , Jens Axboe , Kent Overstreet , Dongsu Park , Mike Snitzer , "Martin K. Petersen" , Ming Lin , linux-nvme@lists.infradead.org Date: Wed, 21 Oct 2015 08:01:19 -0700 In-Reply-To: References: <1439363241-31772-1-git-send-email-mlin@kernel.org> <1439363241-31772-6-git-send-email-mlin@kernel.org> <20151013115011.GA6546@infradead.org> <20151021072126.GA7671@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-21 at 09:39 -0400, Jeff Moyer wrote: > Christoph Hellwig writes: > > > Jens, Ming: > > > > are you fine with the one liner change to get back to the old I/O > > pattern? While it looks like the cards fault I'd like to avoid this > > annoying regression. > > I'm not Jens or Ming, but your patch looks fine to me, though you'll > want to remove the MAX_BIO_SECTORS definition since it's now unused. > It's not clear to me why the limit was lowered in the first place. UINT_MAX >> 9 is not power of 2 and it causes dm-thinp discard fails. At the lengthy discussion: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios We agreed to cap discard to 2G as an interim solution for 4.3 until the dm-thinp discard code is rewritten. Hi Mike, Will the dm-thinp discard rewritten ready for 4.4? Thanks, Ming > > You can add my Reviewed-by: Jeff Moyer if you resend > the patch. > > -Jeff