From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen/device-tree: Print the DT path on error in dt_for_each_range
Date: Thu, 22 Oct 2015 16:56:12 +0100 [thread overview]
Message-ID: <1445529372.2374.31.camel@citrix.com> (raw)
In-Reply-To: <1445259480-16221-1-git-send-email-julien.grall@citrix.com>
On Mon, 2015-10-19 at 13:58 +0100, Julien Grall wrote:
> With the current log is not possible for the user to understand
> properly the error:
>
> (XEN) Grant table range: 0x0000007fc00000-0x0000007fc72000
> (XEN) DT: no ranges; cannot enumerate
> (XEN) Device tree generation failed (-22).
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Could not set up DOM0 guest OS
> (XEN) ****************************************
> (XEN)
>
> The other error message within the function already print the DT path.
> Do the same here.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked + applied.
>
> ---
>
> This patch is a good candidate to backport in Xen 4.6. It helps the
> user to directly know which DT node may be invalid rather than having
> to add debug in Xen.
Queued.
prev parent reply other threads:[~2015-10-22 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:58 [PATCH] xen/device-tree: Print the DT path on error in dt_for_each_range Julien Grall
2015-10-22 15:56 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445529372.2374.31.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.