From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen/device-tree: Print the DT path on error in dt_for_each_range Date: Thu, 22 Oct 2015 16:56:12 +0100 Message-ID: <1445529372.2374.31.camel@citrix.com> References: <1445259480-16221-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpIDw-0006VE-Ag for xen-devel@lists.xenproject.org; Thu, 22 Oct 2015 15:56:16 +0000 In-Reply-To: <1445259480-16221-1-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-10-19 at 13:58 +0100, Julien Grall wrote: > With the current log is not possible for the user to understand > properly the error: > > (XEN) Grant table range: 0x0000007fc00000-0x0000007fc72000 > (XEN) DT: no ranges; cannot enumerate > (XEN) Device tree generation failed (-22). > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Could not set up DOM0 guest OS > (XEN) **************************************** > (XEN) > > The other error message within the function already print the DT path. > Do the same here. > > Signed-off-by: Julien Grall Acked + applied. > > --- > > This patch is a good candidate to backport in Xen 4.6. It helps the > user to directly know which DT node may be invalid rather than having > to add debug in Xen. Queued.