All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] libxl: make libxl_vncviewer_exec work with stubdom
Date: Thu, 22 Oct 2015 17:31:17 +0100	[thread overview]
Message-ID: <1445531477.2374.55.camel@citrix.com> (raw)
In-Reply-To: <1445432829-19310-1-git-send-email-wei.liu2@citrix.com>

On Wed, 2015-10-21 at 14:07 +0100, Wei Liu wrote:
> The xenstore path to look at when stubdom is in used is different. Libxl
> should look at stubdom path instead.

It took me a while to work this out, so please mention that the VNC in
question is the backend corresponding to the stubdom's PVFB (into which it
writes the emulated VGA content) and that the port for that is written into
the PVFB frontend dir, i.e. on the stubdom path.

Or alternatively since semantically this is the guest's console (albiet
laundered through a stubdom) perhaps we should be writing these vnc-* keys
there instead/as well?

Either way these vnc-* keys need to be documented in docs/misc/xenstore
-paths.markdown, either directly or by a reference to pvfb.h (which would
then need to talk about them), so we know what they mean and where they
should live (which in turn may render at least half what I said above
moot).

Ian.

      reply	other threads:[~2015-10-22 16:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 13:07 [PATCH] libxl: make libxl_vncviewer_exec work with stubdom Wei Liu
2015-10-22 16:31 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445531477.2374.55.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.