All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools: create XEN_DUMP_DIR with mode 0700
Date: Thu, 22 Oct 2015 17:32:57 +0100	[thread overview]
Message-ID: <1445531577.2374.57.camel@citrix.com> (raw)
In-Reply-To: <1445436956-22436-1-git-send-email-wei.liu2@citrix.com>

On Wed, 2015-10-21 at 15:15 +0100, Wei Liu wrote:
> That directory is used to store guest memory dump which contains
> sensitive information.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Have you audited all the paths we create and determined that this is the
only one which needs adjusting in this way?

OOI, what lead you to be concerned about the permissions on the directories
we are creating (first the xenpaging one, now this)?

Ian.

  reply	other threads:[~2015-10-22 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 14:15 [PATCH] tools: create XEN_DUMP_DIR with mode 0700 Wei Liu
2015-10-22 16:32 ` Ian Campbell [this message]
2015-10-26 17:15   ` Wei Liu
2015-11-03 17:00   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445531577.2374.57.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.