From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s} Date: Thu, 22 Oct 2015 18:54:00 +0200 Message-ID: <1445532840.6523.57.camel@citrix.com> References: <1445528599-11895-1-git-send-email-julien.grall@citrix.com> <5629216C02000078000ADA46@prv-mh.provo.novell.com> <56290B1A.6030109@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2473294423017255601==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpJ82-0005sI-6K for xen-devel@lists.xenproject.org; Thu, 22 Oct 2015 16:54:14 +0000 In-Reply-To: <56290B1A.6030109@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , Jan Beulich Cc: George Dunlap , Andrew Cooper , Keir Fraser , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============2473294423017255601== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vPp4dFVW8NPMvHjZyjeP" --=-vPp4dFVW8NPMvHjZyjeP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-10-22 at 17:13 +0100, Julien Grall wrote: > On 22/10/15 16:48, Jan Beulich wrote: > > > > > On 22.10.15 at 17:43, wrote: > > > @@ -477,7 +477,7 @@ p2m_pod_offline_or_broken_replace(struct > > > page_info *p) > > > =20 > > > free_domheap_page(p); > > > =20 > > > - p =3D alloc_domheap_page(d, PAGE_ORDER_4K); > > > + p =3D alloc_domheap_page(d, 0); > >=20 > > I realize that this is the easiest fix, but I think here we instead > > want > > something like >=20 > It sounds sensible to me to re-allocate the page on the same numa > node. >=20 Indeed. It may be worth mentioning this in the changelog too, IMHO. > I will send another version of this patch. Although, I would > appreciate > if someone can test it because I don't have any NUMA platform. >=20 I'm up for it... What would it be a reasonable test, that actually stress this? I certainly can do a "regular" test cycle such as: boot --> create a guest --> play a bit with it --> shutdown. Is it enough? I think it should be an HVM guest, right? And perhaps I should specify different mem=3D and memmax=3D ? Just let me know and, if you remember, Cc me when sending next version. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-vPp4dFVW8NPMvHjZyjeP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYpFKgACgkQk4XaBE3IOsQMHACfTChaHfZSrE1GTLmeLq+q4Pg7 vz8An1PVtwds2S3Qav8W+kxSVJ8pelRP =rVo8 -----END PGP SIGNATURE----- --=-vPp4dFVW8NPMvHjZyjeP-- --===============2473294423017255601== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2473294423017255601==--