From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/3] xl: convert scheduling related return codes to EXIT_[SUCCESS|FAILURE] Date: Fri, 23 Oct 2015 12:03:03 +0200 Message-ID: <1445594583.5117.68.camel@citrix.com> References: <1445586491-15093-1-git-send-email-write.harmandeep@gmail.com> <1445589018.5117.8.camel@citrix.com> <1445594181.2374.99.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2590127131855947655==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpZBr-0005nV-9Q for xen-devel@lists.xenproject.org; Fri, 23 Oct 2015 10:03:15 +0000 In-Reply-To: <1445594181.2374.99.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, Lars Kurth , ian.jackson@eu.citrix.com, george.dunlap@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============2590127131855947655== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-sWyD8L2/Gubgx4PANh9L" --=-sWyD8L2/Gubgx4PANh9L Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-10-23 at 10:56 +0100, Ian Campbell wrote: > On Fri, 2015-10-23 at 10:30 +0200, Dario Faggioli wrote: > > Harman, when you send a patch series, as you did here (thanks and > > good > > job doing it so quickly :-) ), you want to include a 'cover > > letter'. That > > is an introductory email, often labelled (usually automatically by > > git > > tools) as patch 0 of the series itself. In it, you give a brief > > explanation of what the series is meant at, and any kind of > > information > > you think the people reviewing the series should have, but that > > wouldn't > > fit in the various patches' changelogs, code comments, etc. >=20 > In particular in this case I would like to know whether all xl > functions > now use EXIT_SUCCESS/FAILURE or if there is still > inconsistencies/work to > be done. >=20 Exactly, Harman, these are the sort of things you'd include in a cover letter for a series like this. > I don't see any existing use of of EXIT_* in xl*. >=20 I sent a patch turning one function into doing so just yesterday. :-) We (me, you and Wei) talked about it a while back (see the changelog of that patch, it has the links): https://www.mail-archive.com/xen-devel@lists.xen.org/msg42850.html And yes, I have it in my todo list to convert all of them. I'm fine with committing to do that for 4.7. This effort from Harman is just me using my todo list items as proposals for preliminary contribution for the sake of applying to Outreacy. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-sWyD8L2/Gubgx4PANh9L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYqBdcACgkQk4XaBE3IOsQ18ACeKj+m2oxgXRyM5I1AneUTbVaZ k3MAnjJ3pgUZR9hLGIjFzgHy7o83AawD =ARAN -----END PGP SIGNATURE----- --=-sWyD8L2/Gubgx4PANh9L-- --===============2590127131855947655== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2590127131855947655==--