From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 3/6] xen: sched: clarify use cases of schedule_cpu_switch() Date: Fri, 23 Oct 2015 15:53:55 +0200 Message-ID: <1445608435.5117.129.camel@citrix.com> References: <20151014151805.28642.63981.stgit@Solace.station> <20151014155416.28642.76465.stgit@Solace.station> <561F630B.5080401@suse.com> <1445447429.3009.209.camel@citrix.com> <562A3958.1000207@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1410235320377485834==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpcnB-0006kW-I2 for xen-devel@lists.xenproject.org; Fri, 23 Oct 2015 13:54:01 +0000 In-Reply-To: <562A3958.1000207@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============1410235320377485834== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-DBqtx/4Wn6z/ASO5TRjo" --=-DBqtx/4Wn6z/ASO5TRjo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-10-23 at 15:42 +0200, Juergen Gross wrote: > On 10/21/2015 07:10 PM, Dario Faggioli wrote: > > Also, all the operations done in schedule_cpu_switch() itself, > > depend > > either on per_cpu(scheduler) or on per_cpu(schedule_data) being > > updated > > properly, rather than on per_cpu(cpupool) (including the locking > > that > > you are mentioning above). > >=20 > > What am I missing? >=20 > Hmm, good question. I'm rather sure I had a problem related to > exactly > this topic in the early days of cpupools. Maybe the critical code has > been modified since then. Or my memory is wrong.=20 > =46rom a quick archeological investigation, some things certainly have changed. Still, I can't spot anything directly related to this, but it's quite possible that it's there and I'm missing it. > Or we both don't see > it now. ;-) >=20 Yep! :-) > In case there is a problem it should show up doing a test which > concurrently does all of the following: >=20 > - move a domain between two cpupools > - move a cpu between the two cpupools > - create and destroy a domain in one of the two cpupools >=20 Ok, I'll arrange for this and report. > If the system is surviving this test for a couple of hours you are > fine > and then for the attached patch: >=20 > Acked-by: Juergen Gross >=20 Thanks :-) Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-DBqtx/4Wn6z/ASO5TRjo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYqO/MACgkQk4XaBE3IOsQxaACgj853EWyuZPkovuxuYeXuW/vW QIUAn3jtiUTiYSx1h5In0xu/+JwEdIkR =t+Po -----END PGP SIGNATURE----- --=-DBqtx/4Wn6z/ASO5TRjo-- --===============1410235320377485834== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1410235320377485834==--