From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xl: log an error if libxl_cpupool_destroy() fails Date: Fri, 23 Oct 2015 18:07:57 +0200 Message-ID: <1445616477.5117.176.camel@citrix.com> References: <20151022171420.15122.92760.stgit@Solace.station> <20151023084326.GN5060@zion.uk.xensource.com> <1445609376.2374.192.camel@citrix.com> <1445613170.5117.139.camel@citrix.com> <1445614849.2374.223.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0664700264997383389==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zpesy-00047r-Ky for xen-devel@lists.xenproject.org; Fri, 23 Oct 2015 16:08:08 +0000 In-Reply-To: <1445614849.2374.223.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Wei Liu , Ian Jackson Cc: Juergen Gross , xen-devel@lists.xenproject.org, Harmandeep Kaur , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============0664700264997383389== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-jAdpgOqlu4f+ajKxDVko" --=-jAdpgOqlu4f+ajKxDVko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-10-23 at 16:40 +0100, Ian Campbell wrote: > On Fri, 2015-10-23 at 17:12 +0200, Dario Faggioli wrote: > > On Fri, 2015-10-23 at 15:09 +0100, Ian Campbell wrote: > > > I think what I would have been expecting is for the xl internal > > > error > > > code > > Well, same here. Except, given xl architecture, I was considering > > main_foo() functions in xl_cmdimpl.c as some king of extensions of > > the > > actual main function. >=20 > I had somehow convinced myself that these weren't being added in a > main_foo, I agree that main_foo should be treated somewhat like a > regular > main(). >=20 Ok, glad to see we're on the same page. > Sorry for the noise. >=20 NP. :-) > > I'm fine with either, so, if you prefer the latter, I certainly can > > arrange for doing things that way. >=20 > It would be helpful to a) not combine this change with the logging=20 > change > Sure, I'll resend the patch without changing that. > b) include as part of the patch some sort of document comment in > some relevant xl-ish place explaining some of this stuff (i.e. that > an xl > process should always return EXIT_FOO and that main_* can be treated > like > main() as if they are returning a process exit status and not a > function > return value). >=20 About this... > I think it would also be useful to have xl's main() DTRT before > starting to convert main_*. Currently it returns explicit 0 or 1 or > the result of the main_*. >=20 ... and this, I'll see if I can convince Harman to pick these up, as part of her work on the subject. :-P :-P Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-jAdpgOqlu4f+ajKxDVko Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYqW10ACgkQk4XaBE3IOsR6oQCdEguxu7hVsJo9OfOl45rhgDGu VewAnRY0dYFIV4h/LdStFsnnTGfBYS22 =ZJMr -----END PGP SIGNATURE----- --=-jAdpgOqlu4f+ajKxDVko-- --===============0664700264997383389== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0664700264997383389==--