From: Ben Boeckel <mathstuf@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libcap: depend on host-attr for the host
Date: Sat, 24 Oct 2015 17:39:14 -0400 [thread overview]
Message-ID: <1445722754-3477-2-git-send-email-mathstuf@gmail.com> (raw)
In-Reply-To: <1445722754-3477-1-git-send-email-mathstuf@gmail.com>
When a host-libcap is built, it is built without libattr support.
However, libcap does not define some symbols based on this flag. This
becomes a problem when a build-host tool is run (e.g., ls) which uses
these symbols gets the host-libcap library via LD_LIBRARY_PATH.
In order to define all of the symbols, add libattr support on the host.
The RAISE_SETFCAP setting must also be disabled since the required
permissions are not available during install.
Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
package/attr/attr.mk | 1 +
package/libcap/libcap.mk | 9 ++++-----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/package/attr/attr.mk b/package/attr/attr.mk
index a66891b..7dac7cf 100644
--- a/package/attr/attr.mk
+++ b/package/attr/attr.mk
@@ -37,3 +37,4 @@ endef
ATTR_POST_INSTALL_STAGING_HOOKS += ATTR_FIX_LIBTOOL_LA_LIBDIR
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
diff --git a/package/libcap/libcap.mk b/package/libcap/libcap.mk
index 54844f8..65057e5 100644
--- a/package/libcap/libcap.mk
+++ b/package/libcap/libcap.mk
@@ -20,8 +20,7 @@ else
LIBCAP_HAVE_LIBATTR = no
endif
-# we don't have host-attr
-HOST_LIBCAP_DEPENDENCIES =
+HOST_LIBCAP_DEPENDENCIES = host-attr
ifeq ($(BR2_STATIC_LIBS),y)
LIBCAP_MAKE_TARGET = libcap.a
@@ -67,12 +66,12 @@ define LIBCAP_INSTALL_TARGET_CMDS
endef
define HOST_LIBCAP_BUILD_CMDS
- $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) LIBATTR=no
+ $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)
endef
define HOST_LIBCAP_INSTALL_CMDS
- $(HOST_MAKE_ENV) $(MAKE) -C $(@D) LIBATTR=no DESTDIR=$(HOST_DIR) \
- prefix=/usr lib=lib install
+ $(HOST_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
+ RAISE_SETFCAP=no prefix=/usr lib=lib install
endef
$(eval $(generic-package))
--
2.6.2
next prev parent reply other threads:[~2015-10-24 21:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 21:39 [Buildroot] [PATCH 0/1] Build host-libcap with libattr support Ben Boeckel
2015-10-24 21:39 ` Ben Boeckel [this message]
2015-10-26 8:58 ` [Buildroot] [PATCH 1/1] libcap: depend on host-attr for the host Thomas Petazzoni
2015-10-26 14:27 ` Ben Boeckel
2015-10-27 6:29 ` Thomas Petazzoni
2015-10-29 2:49 ` Ben Boeckel
2015-10-29 2:48 ` [Buildroot] [PATCH] makefile: remove LD_LIBRARY_PATH from the environment Ben Boeckel
2015-11-13 1:37 ` Ben Boeckel
2015-11-13 6:37 ` Arnout Vandecappelle
2015-11-13 9:00 ` Yann E. MORIN
2015-11-13 22:19 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445722754-3477-2-git-send-email-mathstuf@gmail.com \
--to=mathstuf@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.