From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] Fixing coverity bug CID1311511 Date: Mon, 26 Oct 2015 10:09:15 +0100 Message-ID: <1445850555.2717.8.camel@citrix.com> References: <1445767344-7780-1-git-send-email-comethalley61@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0512963577165555756==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqdmd-00031U-SN for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 09:09:39 +0000 In-Reply-To: <1445767344-7780-1-git-send-email-comethalley61@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Lasya Venneti , xen-devel@lists.xenproject.org, george.dunlap@citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com, stefano.stebellini@eu.citrix.com, lars.kurth@citrix.com List-Id: xen-devel@lists.xenproject.org --===============0512963577165555756== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-gIsL2MyiZaYmTYsa7SS3" --=-gIsL2MyiZaYmTYsa7SS3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2015-10-25 at 15:32 +0530, Lasya Venneti wrote: > *This is part of my 'bite sized contribution' to Xen for the > OutreachY program.=20 >=20 > *The change handles the return value of the function xc_dom_allocate, > if the function returns NULL the function returns -1. It would not be > useful to jump to err as err would check !dom for NULL.=20 >=20 But then you're not closing xs_fd, is that ok? (I'm asking, because I am not at all a xenstore expert, but, FWIW, it does not feel right to me). > *Changes have been made in the build function in init-xenstore > -domain.c >=20 > *I have taken these discussions for reference: > https://www.choon.net/forum/read.php?22,3805351,3805351 >=20 > Signed-off: Lasya Venneti > Most of this (except the first bullet point, perhaps), and especially the Signed-off-by (it's 'Signed-off-by:', not 'Signed-off') tag goes in the patch changelog. In fact: - this looks like a cover letter for a patch series, but there is=20 only one patch in this case. Usually, when there is only one patch,=20 you don't need a cover letter (there are exceptions, but I don't=20 think this qualifies); - cover letters, no matter whether for series or single patches, do=20 not become part of the source tree, when the patch (series) is=20 committed. That is why, information about the patch=20 content/design/etc. and the tags must live in the changelog. If you=20 do like this, someone looking at `git log' wouldn't see it. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-gIsL2MyiZaYmTYsa7SS3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYt7bsACgkQk4XaBE3IOsSRDACfbilhM4b5iPvK8RQfppJiXL3k 6TgAnjLE7iaBKMTyMjR56waY/4mZZPXz =+sFr -----END PGP SIGNATURE----- --=-gIsL2MyiZaYmTYsa7SS3-- --===============0512963577165555756== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0512963577165555756==--