From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keller, Jacob E Date: Mon, 26 Oct 2015 20:50:45 +0000 Subject: [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of max frame size In-Reply-To: <562D7A33.4020603@lab.ntt.co.jp> References: <1445572173-15402-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <562B4673.7020608@gmail.com> <562D7A33.4020603@lab.ntt.co.jp> Message-ID: <1445892645.15482.3.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Mon, 2015-10-26 at 09:56 +0900, Toshiaki Makita wrote: > On 2015/10/24 17:50, Toshiaki Makita wrote: > > David, > > > > I found my patch set is marked with Changes Requested, but I > > haven't > > seen any feedback. > > > > Could you give me your feedback? > > Somehow the mail from LD Linux CI Server did not reach netdev mailing > list so I could not have seen it from gmail... > > Toshiaki Makita > the ND Linux Bot is only checking against the Intel mailing list intel-wired-lan at lists.osuosl.org, and isn't subscribed to netdev. I am not sure why it failed to mail to it, unless netdev blocks non subscribers from sending mail (it probably does) The checkpatch output here is likely ignorable, note how it shows up as a warning. You can fix them if you feel there is a reasonable way to shorten the line. In this case, I probably wouldn't unless you want to perform the VLAN and ETH_FRAME LEN calculation once somewhere else... Generally being close to 80, (81,82 etc) is probably ok, as long as there isn't an obvious nicer way to shorten the line. Regards, Jake From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: Re: [PATCH net-next 0/4] Automatic adjustment of max frame size Date: Mon, 26 Oct 2015 20:50:45 +0000 Message-ID: <1445892645.15482.3.camel@intel.com> References: <1445572173-15402-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <562B4673.7020608@gmail.com> <562D7A33.4020603@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "stephen@networkplumber.org" , "toshiaki.makita1@gmail.com" , "kaber@trash.net" , "vyasevich@gmail.com" , "intel-wired-lan@lists.osuosl.org" , "Kirsher, Jeffrey T" , "netdev@vger.kernel.org" To: "makita.toshiaki@lab.ntt.co.jp" , "davem@davemloft.net" Return-path: Received: from mga02.intel.com ([134.134.136.20]:41943 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964AbbJZUur (ORCPT ); Mon, 26 Oct 2015 16:50:47 -0400 In-Reply-To: <562D7A33.4020603@lab.ntt.co.jp> Content-Language: en-US Content-ID: <54428446194C2E4986B23DBEDA41E8DC@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDE1LTEwLTI2IGF0IDA5OjU2ICswOTAwLCBUb3NoaWFraSBNYWtpdGEgd3JvdGU6 DQo+IE9uIDIwMTUvMTAvMjQgMTc6NTAsIFRvc2hpYWtpIE1ha2l0YSB3cm90ZToNCj4gPiBEYXZp ZCwNCj4gPiANCj4gPiBJIGZvdW5kIG15IHBhdGNoIHNldCBpcyBtYXJrZWQgd2l0aCBDaGFuZ2Vz IFJlcXVlc3RlZCwgYnV0IEkNCj4gPiBoYXZlbid0DQo+ID4gc2VlbiBhbnkgZmVlZGJhY2suDQo+ ID4gDQo+ID4gQ291bGQgeW91IGdpdmUgbWUgeW91ciBmZWVkYmFjaz8NCj4gDQo+IFNvbWVob3cg dGhlIG1haWwgZnJvbSBMRCBMaW51eCBDSSBTZXJ2ZXIgZGlkIG5vdCByZWFjaCBuZXRkZXYgbWFp bGluZw0KPiBsaXN0IHNvIEkgY291bGQgbm90IGhhdmUgc2VlbiBpdCBmcm9tIGdtYWlsLi4uDQo+ IA0KPiBUb3NoaWFraSBNYWtpdGENCj4gDQoNCnRoZSBORCBMaW51eCBCb3QgaXMgb25seSBjaGVj a2luZyBhZ2FpbnN0IHRoZSBJbnRlbCBtYWlsaW5nIGxpc3QgIA0KaW50ZWwtd2lyZWQtbGFuQGxp c3RzLm9zdW9zbC5vcmcsIGFuZCBpc24ndCBzdWJzY3JpYmVkIHRvIG5ldGRldi4NCg0KSSBhbSBu b3Qgc3VyZSB3aHkgaXQgZmFpbGVkIHRvIG1haWwgdG8gaXQsIHVubGVzcyBuZXRkZXYgYmxvY2tz IG5vbg0Kc3Vic2NyaWJlcnMgZnJvbSBzZW5kaW5nIG1haWwgKGl0IHByb2JhYmx5IGRvZXMpDQoN ClRoZSBjaGVja3BhdGNoIG91dHB1dCBoZXJlIGlzIGxpa2VseSBpZ25vcmFibGUsIG5vdGUgaG93 IGl0IHNob3dzIHVwIGFzDQphIHdhcm5pbmcuIFlvdSBjYW4gZml4IHRoZW0gaWYgeW91IGZlZWwg dGhlcmUgaXMgYSByZWFzb25hYmxlIHdheSB0bw0Kc2hvcnRlbiB0aGUgbGluZS4gSW4gdGhpcyBj YXNlLCBJIHByb2JhYmx5IHdvdWxkbid0IHVubGVzcyB5b3Ugd2FudCB0bw0KcGVyZm9ybSB0aGUg VkxBTiBhbmQgRVRIX0ZSQU1FIExFTiBjYWxjdWxhdGlvbiBvbmNlIHNvbWV3aGVyZSBlbHNlLi4u DQoNCkdlbmVyYWxseSBiZWluZyBjbG9zZSB0byA4MCwgKDgxLDgyIGV0YykgaXMgcHJvYmFibHkg b2ssIGFzIGxvbmcgYXMNCnRoZXJlIGlzbid0IGFuIG9idmlvdXMgbmljZXIgd2F5IHRvIHNob3J0 ZW4gdGhlIGxpbmUuDQoNClJlZ2FyZHMsDQpKYWtl