Re: [PATCH v4 2/5] xl: improve return and exit codes of scheduling related functions

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1470 bytes --]

On Tue, 2015-10-27 at 13:50 +0000, Wei Liu wrote:
> On Tue, Oct 27, 2015 at 06:18:55PM +0530, Harmandeep Kaur wrote:

> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index 646b281..b101aff 100644
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -5793,18 +5793,15 @@ int main_sharing(int argc, char **argv)
> >  static int sched_domain_get(libxl_scheduler sched, int domid,
> >                              libxl_domain_sched_params *scinfo)
> >  {
> > -    int rc;
> > -
> > -    rc = libxl_domain_sched_params_get(ctx, domid, scinfo);
> > -    if (rc) {
> > +    if (libxl_domain_sched_params_get(ctx, domid, scinfo)){
> 
> This, and other instances in both patch 2 and 3, violates coding
> style.
> You need to have a space before "{".
> 
Bha, I guess I was concentrating on the "return / exit()" changes, and
managed to miss these! :-/

> After that, you can add my ack to all your patches. I haven't
> carefully
> read through every line of change, but I think Dario's review is
> sufficient
> and thorough. 
>
And yet, I managed to miss those coding style issues. :-(

> Thanks Dario.
> 
Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel