From: Dario Faggioli <dario.faggioli@citrix.com>
To: Lasya <comethalley61@gmail.com>,
xen-devel@lists.xenproject.org, george.dunlap@citrix.com,
lars.kurth@citrix.com, wei.liu2@citrix.com,
ian.campbell@citrix.com
Subject: Re: [PATCH v3] Leaking of xs_fd fixed in Xenstore
Date: Wed, 28 Oct 2015 02:03:09 +0100 [thread overview]
Message-ID: <1445994189.2937.241.camel@citrix.com> (raw)
In-Reply-To: <1445991183-9208-1-git-send-email-comethalley61@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 671 bytes --]
On Wed, 2015-10-28 at 05:43 +0530, Lasya wrote:
> The success path isn't closed xs_fd in build function in init
> -xenstore-domain.c . Added that line before return 0.
>
All that I said for the other patch, applies here too.
Also, the two patches are related. I think it would be good if you try
sending them as a patch series, rather than as two independent patches.
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-10-28 1:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 0:13 [PATCH v3] Leaking of xs_fd fixed in Xenstore Lasya
2015-10-28 1:03 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445994189.2937.241.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=comethalley61@gmail.com \
--cc=george.dunlap@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=lars.kurth@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.