From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Dima Kogan <dima@secretsauce.net>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 09/12] perf symbols: Fix type error when reading a build-id
Date: Wed, 28 Oct 2015 12:30:59 -0300 [thread overview]
Message-ID: <1446046262-997-10-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1446046262-997-1-git-send-email-acme@kernel.org>
From: Dima Kogan <dima@secretsauce.net>
This was benign, but wrong. The build-id should live in a char[], not a char*[]
Signed-off-by: Dima Kogan <dima@secretsauce.net>
Link: http://lkml.kernel.org/r/87si6pfwz4.fsf@secretsauce.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol-minimal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c
index fd8477cacf88..48906333a858 100644
--- a/tools/perf/util/symbol-minimal.c
+++ b/tools/perf/util/symbol-minimal.c
@@ -337,7 +337,7 @@ int dso__load_sym(struct dso *dso, struct map *map __maybe_unused,
symbol_filter_t filter __maybe_unused,
int kmodule __maybe_unused)
{
- unsigned char *build_id[BUILD_ID_SIZE];
+ unsigned char build_id[BUILD_ID_SIZE];
int ret;
ret = fd__is_64_bit(ss->fd);
--
2.1.0
next prev parent reply other threads:[~2015-10-28 15:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 15:30 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 01/12] perf tools: Improve ambiguous option help message Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 02/12] perf report: Rename to --show-cpu-utilization Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 03/12] perf tools: Setup pager when printing usage and help Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 04/12] perf tools: Introduce usage_with_options_msg() Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 05/12] perf evsel: Move id_offset out of struct perf_evsel union member Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 06/12] perf cpu_map: Add cpu_map__empty_new function Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 07/12] perf stat: Cache aggregated map entries in extra cpumap Arnaldo Carvalho de Melo
2015-10-28 15:30 ` [PATCH 08/12] perf tools: Search for more options when passing args to -h Arnaldo Carvalho de Melo
2015-10-28 15:30 ` Arnaldo Carvalho de Melo [this message]
2015-10-28 15:31 ` [PATCH 10/12] perf symbols: we can now read separate debug-info files based on a build ID Arnaldo Carvalho de Melo
2015-10-28 15:31 ` [PATCH 11/12] perf tools: Enable pre-event inherit setting by config terms Arnaldo Carvalho de Melo
2015-10-28 15:31 ` [PATCH 12/12] perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore Arnaldo Carvalho de Melo
2015-10-29 9:36 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar
2015-10-29 9:51 ` Ingo Molnar
2015-10-29 9:55 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446046262-997-10-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=dima@secretsauce.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.