From: Johannes Thumshirn <jthumshirn@suse.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>, linux-scsi@vger.kernel.org
Cc: y2038@lists.linaro.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RESEND PATCH] qla2xxx: Remove use of 'struct timeval'
Date: Fri, 30 Oct 2015 10:36:16 +0100 [thread overview]
Message-ID: <1446197776.16404.57.camel@suse.de> (raw)
In-Reply-To: <20151030091526.GA4028@tina-laptop>
On Fri, 2015-10-30 at 02:15 -0700, Tina Ruchandani wrote:
> struct register_host_info stores a 64-bit UTC system time timestamp.
> This patch removes the use of 'struct timeval' to obtain that
> timestamp
> as its tv_sec value will overflow on 32-bit systems in year 2038
> beyond.
> The patch uses ktime_get_real_seconds() which returns a 64-bit
> seconds value.
>
> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_mr.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_mr.c
> b/drivers/scsi/qla2xxx/qla_mr.c
> index 6d190b4..d64a64a 100644
> --- a/drivers/scsi/qla2xxx/qla_mr.c
> +++ b/drivers/scsi/qla2xxx/qla_mr.c
> @@ -6,6 +6,7 @@
> */
> #include "qla_def.h"
> #include <linux/delay.h>
> +#include <linux/ktime.h>
> #include <linux/pci.h>
> #include <linux/ratelimit.h>
> #include <linux/vmalloc.h>
> @@ -1812,7 +1813,6 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t
> *fcport, uint16_t fx_type)
> struct host_system_info *phost_info;
> struct register_host_info *preg_hsi;
> struct new_utsname *p_sysid = NULL;
> - struct timeval tv;
>
> sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
> if (!sp)
> @@ -1886,8 +1886,7 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t
> *fcport, uint16_t fx_type)
> p_sysid->domainname, DOMNAME_LENGTH);
> strncpy(phost_info->hostdriver,
> QLA2XXX_VERSION, VERSION_LENGTH);
> - do_gettimeofday(&tv);
> - preg_hsi->utc = (uint64_t)tv.tv_sec;
> + preg_hsi->utc =
> (uint64_t)ktime_get_real_seconds();
> ql_dbg(ql_dbg_init, vha, 0x0149,
> "ISP%04X: Host registration with
> firmware\n",
> ha->pdev->device);
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
next prev parent reply other threads:[~2015-10-30 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 9:15 [RESEND PATCH] qla2xxx: Remove use of 'struct timeval' Tina Ruchandani
2015-10-30 9:36 ` Johannes Thumshirn [this message]
2015-11-05 16:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446197776.16404.57.camel@suse.de \
--to=jthumshirn@suse.de \
--cc=JBottomley@parallels.com \
--cc=arnd@arndb.de \
--cc=linux-scsi@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.