From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3] dom variable error handled in Xenstore
Date: Fri, 30 Oct 2015 15:28:43 +0100
Message-ID: <1446215323.28782.120.camel@citrix.com>
References: <1445991143-9165-1-git-send-email-comethalley61@gmail.com>
	<1445994047.2937.238.camel@citrix.com>
	<CAAbK42_w=9UxpJcPTkRvT__dtOM9y+zd1_v7zdkdpm0KE6p3xQ@mail.gmail.com>
	<20151029100728.GB8097@zion.uk.xensource.com>
	<1446113517.28782.50.camel@citrix.com>
	<CAAbK42_VEpvM+1_KnJ5GXY859Afv03iVcT0h6YU2dzhT7yZUjw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3733842256975843929=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7383c55b7=dario.faggioli@citrix.com>)
	id 1ZsAfp-00013Y-Pw
	for xen-devel@lists.xenproject.org; Fri, 30 Oct 2015 14:28:57 +0000
In-Reply-To: <CAAbK42_VEpvM+1_KnJ5GXY859Afv03iVcT0h6YU2dzhT7yZUjw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Lasya Venneti <comethalley61@gmail.com>
Cc: xen-devel@lists.xenproject.org, Lars Kurth <lars.kurth@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, George Dunlap <george.dunlap@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============3733842256975843929==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-KOqZMFGxKbMpjbTOXvrv"

--=-KOqZMFGxKbMpjbTOXvrv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-10-29 at 20:28 +0530, Lasya Venneti wrote:
>=20
>=20
> On 29 October 2015 at 15:41, Dario Faggioli <
> dario.faggioli@citrix.com> wrote:
> > On Thu, 2015-10-29 at 10:07 +0000, Wei Liu wrote:

> > > As for xc_dom_allocate, the only failure path at the moment is
> > malloc
> > > failure, which would be appropriate to use ENOMEM to represent.
> > >
> > > However if it causes too many faffs, you can just set rv to -1
> > and
> > > return to caller. I think the main point is to handle the error,
> > > either
> > > -1 or ENOMEM is fine by me.
> > >
> > Agreed but, I personally prefer -1, for consistency. :-)
> >=20
> So should I proceed with -1? In that case I don't need to add the
> header...
> =20
If you're still up for this (and for the other patch, which would be
great!), yes, go for -1.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-KOqZMFGxKbMpjbTOXvrv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYzfpsACgkQk4XaBE3IOsRbmQCeMb7fIH3m9DuuJyV1qiGnnkWY
qaMAnRnnce6IuV6g5IIsNfST1G+dP7Is
=c3Op
-----END PGP SIGNATURE-----

--=-KOqZMFGxKbMpjbTOXvrv--


--===============3733842256975843929==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3733842256975843929==--