From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harmandeep Kaur Subject: [PATCH] sched_credit: Remove cpu argument to __runq_insert() Date: Fri, 30 Oct 2015 20:39:53 +0530 Message-ID: <1446217794-22320-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZsBL2-0001kr-2e for xen-devel@lists.xenproject.org; Fri, 30 Oct 2015 15:11:32 +0000 Received: by pacfv9 with SMTP id fv9so80231129pac.3 for ; Fri, 30 Oct 2015 08:11:29 -0700 (PDT) List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org __runq_insert() takes two arguments, cpu and svc. However, the cpu argument is redundant because we can get all the information we need about cpu from svc. Signed-off-by: Harmandeep Kaur --- xen/common/sched_credit.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index b8f28fe..5d73706 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -252,13 +252,12 @@ __runq_elem(struct list_head *elem) } static inline void -__runq_insert(unsigned int cpu, struct csched_vcpu *svc) +__runq_insert(struct csched_vcpu *svc) { - const struct list_head * const runq = RUNQ(cpu); + const struct list_head * const runq = RUNQ(svc->vcpu->processor); struct list_head *iter; BUG_ON( __vcpu_on_runq(svc) ); - BUG_ON( cpu != svc->vcpu->processor ); list_for_each( iter, runq ) { @@ -905,7 +904,7 @@ csched_vcpu_insert(const struct scheduler *ops, struct vcpu *vc) struct csched_vcpu *svc = vc->sched_priv; if ( !__vcpu_on_runq(svc) && vcpu_runnable(vc) && !vc->is_running ) - __runq_insert(vc->processor, svc); + __runq_insert(svc); SCHED_STAT_CRANK(vcpu_insert); } @@ -1016,7 +1015,7 @@ csched_vcpu_wake(const struct scheduler *ops, struct vcpu *vc) } /* Put the VCPU on the runq and tickle CPUs */ - __runq_insert(cpu, svc); + __runq_insert(svc); __runq_tickle(cpu, svc); } @@ -1681,7 +1680,7 @@ csched_schedule( * Select next runnable local VCPU (ie top of local runq) */ if ( vcpu_runnable(current) ) - __runq_insert(cpu, scurr); + __runq_insert(scurr); else BUG_ON( is_idle_vcpu(current) || list_empty(runq) ); -- 1.9.1