From: Dario Faggioli <dario.faggioli@citrix.com>
To: Harmandeep Kaur <write.harmandeep@gmail.com>,
xen-devel@lists.xenproject.org
Cc: keir@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com,
jbeulich@suse.com, tim@xen.org
Subject: Re: [PATCH] sched_credit: Remove cpu argument to __runq_insert()
Date: Fri, 30 Oct 2015 17:46:55 +0100 [thread overview]
Message-ID: <1446223615.28782.162.camel@citrix.com> (raw)
In-Reply-To: <1446217794-22320-1-git-send-email-write.harmandeep@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 976 bytes --]
On Fri, 2015-10-30 at 20:39 +0530, Harmandeep Kaur wrote:
> __runq_insert() takes two arguments, cpu and svc. However,
> the cpu argument is redundant because we can get all the
> information we need about cpu from svc.
>
> Signed-off-by: Harmandeep Kaur <write.harmandeep@gmail.com>
>
Thanks Harman, this looks good. Just one thing.
The list of people you Cc-ed, is not really accurate. In fact, Ian
Campbell and Ian Jackson are toolstack maintainers, and even Jan, Keir
and Tim, although they are hypervisors maintainers, should not need to
be bothered by a patch touching only sched_credit.c.
Have a look at the MAINTAINERS file and at scripts/get_maintainer.pl.
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-10-30 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:09 [PATCH] sched_credit: Remove cpu argument to __runq_insert() Harmandeep Kaur
2015-10-30 16:25 ` Jan Beulich
2015-10-30 16:33 ` Dario Faggioli
2015-10-30 17:00 ` Jan Beulich
2015-11-02 11:01 ` Dario Faggioli
2015-11-03 10:16 ` George Dunlap
2015-11-03 12:38 ` Jan Beulich
2015-11-03 21:22 ` Dario Faggioli
2015-10-30 16:46 ` Dario Faggioli [this message]
2015-10-30 16:50 ` Harmandeep Kaur
2015-10-30 17:01 ` Dario Faggioli
2015-11-02 12:36 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446223615.28782.162.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=write.harmandeep@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.