From: Joe Perches <joe@perches.com>
To: Bogicevic Sasa <brutallesale@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters
Date: Sat, 31 Oct 2015 08:57:08 -0700 [thread overview]
Message-ID: <1446307028.2757.210.camel@perches.com> (raw)
In-Reply-To: <1446300051-12151-1-git-send-email-brutallesale@gmail.com>
On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote:
> This fixes line over 80 characters message from checkpatch.pl
[]
> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
[]
> @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
>
> spin_lock_irqsave(&qcb->qos_lock, flags);
> qcb->csr[index].sfid = sfid;
> - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
> + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
> + 0xff00);
Probably better to remove the unnecessary parentheses instead
qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00;
next prev parent reply other threads:[~2015-10-31 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 14:00 [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa
2015-10-31 15:57 ` Joe Perches [this message]
2015-10-31 16:39 ` Bogicevic Sasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446307028.2757.210.camel@perches.com \
--to=joe@perches.com \
--cc=brutallesale@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.