From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbbJaSnR (ORCPT ); Sat, 31 Oct 2015 14:43:17 -0400 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:37328 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750701AbbJaSnQ (ORCPT ); Sat, 31 Oct 2015 14:43:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:960:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3873:3874:4321:5007:6261:8603:10004:10400:10848:11026:11232:11658:11914:12043:12114:12438:12517:12519:12663:12740:21060:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: dog48_90c29647e6a01 X-Filterd-Recvd-Size: 3031 Message-ID: <1446316993.2757.222.camel@perches.com> Subject: Re: [PATCH] drivers:staging:gdm72xx Fix line over 80 characters From: Joe Perches To: Bogicevic Sasa Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Date: Sat, 31 Oct 2015 11:43:13 -0700 In-Reply-To: <20151031171416.GA19945@gmail.com> References: <1446309480-17917-1-git-send-email-brutallesale@gmail.com> <1446310672.2757.219.camel@perches.com> <20151031171416.GA19945@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-10-31 at 18:14 +0100, Bogicevic Sasa wrote: > On 10/31, Joe Perches wrote: > >On Sat, 2015-10-31 at 17:38 +0100, Bogicevic Sasa wrote: > >> This fixes line over 80 character messages from checkpatch.pl > >[] > >> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c > >[] > >> @@ -382,7 +382,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) > >> > >> spin_lock_irqsave(&qcb->qos_lock, flags); > >> qcb->csr[index].sfid = sfid; > >> - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00); > >> + qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00; > >> qcb->csr[index].classifier_rule_en += buf[pos++]; > >> if (qcb->csr[index].classifier_rule_en == 0) > >> qcb->qos_null_idx = index; > > > >If you do this one, please do all of them in the > >same block. > > > > qcb->csr[index].srcport_lo = ((buf[pos++]<<8)&0xff00); > > qcb->csr[index].srcport_lo += buf[pos++]; > > qcb->csr[index].srcport_hi = ((buf[pos++]<<8)&0xff00); > > qcb->csr[index].srcport_hi += buf[pos++]; > > qcb->csr[index].dstport_lo = ((buf[pos++]<<8)&0xff00); > > qcb->csr[index].dstport_lo += buf[pos++]; > > qcb->csr[index].dstport_hi = ((buf[pos++]<<8)&0xff00); > > > >It'd probably be nicer to use a temporary for > >qcb->csr[index] too. > > > >Also, the += is kind of odd. These are really a > >le16_to_cpu conversion, so it might be nicer to use > >that mechanism. > > > > csr->srcport_lo = get_unaligned_le16(&buf[pos]); > > pos += 2; > > > > > It is not a problem to remove unnecesarry brackets but bear in mind I am > new to bitwise stuff. No worries, it's not that obvious. > So how it should be, like this? > > qcb->csr[index].srcport_lo = get_unaligned_le16(&buf[pos]); > pos += 2; > qcb->csr[index].srcport_lo = buf[pos]; No, it'd be: csr->srcport_lo = get_unaligned_le16(&buf[pos]); pos += 2; csr->srcport_hi = get_unaligned_le16(&buf[pos]); pos += 2; csr->dstport_lo = get_unaligned_le16(&buf[pos]); pos += 2; csr->dstport_hi = get_unaligned_le16(&buf[pos]); pos += 2;