From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christian Fetzer <fetzer.ch@gmail.com>, linux-i2c@vger.kernel.org
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
galandilias@gmail.com
Subject: Re: [PATCH v2 5/5] i2c-piix4: Add adapter port name support for SB800 chipset
Date: Mon, 02 Nov 2015 14:12:43 +0200 [thread overview]
Message-ID: <1446466363.6332.94.camel@linux.intel.com> (raw)
In-Reply-To: <1446395529-9987-6-git-send-email-fetzer.ch@gmail.com>
On Sun, 2015-11-01 at 17:32 +0100, Christian Fetzer wrote:
> This patch adds support for port names for the SB800 chipset.
> Since the chipset supports a multiplexed main SMBus controller,
> adding
> the channel name to the adapter name is necessary to differentiate
> the
> ports better (for example in sensors output).
> +static const char *piix4_main_port_names_sb800[4] = {
Would it be constant you defined instead of magic number?
> + "SDA0", "SDA2", "SDA3", "SDA4"
> +};
> +static const char *piix4_aux_port_name_sb800 = "SDA1";
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2015-11-02 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 16:32 [PATCH v2 0/5] Support multiplexed main SMBus interface on SB80 Christian Fetzer
2015-11-01 16:32 ` [PATCH v2 1/5] i2c-piix4: Optionally release smba in piix4_adap_remove Christian Fetzer
2015-11-02 10:46 ` Mika Westerberg
2015-11-01 16:32 ` [PATCH v2 2/5] i2c-piix4: Convert piix4_main_adapter to array Christian Fetzer
2015-11-02 10:47 ` Mika Westerberg
2015-11-02 11:55 ` Andy Shevchenko
2015-11-01 16:32 ` [PATCH v2 3/5] i2c-piix4: Request base address index region once for SB800 Christian Fetzer
2015-11-02 10:53 ` Mika Westerberg
2015-11-02 12:02 ` Andy Shevchenko
2015-11-01 16:32 ` [PATCH v2 4/5] i2c-piix4: Add support for multiplexed main adapter in SB800 Christian Fetzer
2015-11-02 10:59 ` Mika Westerberg
2015-11-02 12:09 ` Andy Shevchenko
2015-11-01 16:32 ` [PATCH v2 5/5] i2c-piix4: Add adapter port name support for SB800 chipset Christian Fetzer
2015-11-02 11:03 ` Mika Westerberg
2015-11-02 12:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446466363.6332.94.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=fetzer.ch@gmail.com \
--cc=galandilias@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.