From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] xl: Die on unknown options
Date: Tue, 3 Nov 2015 16:59:58 +0000 [thread overview]
Message-ID: <1446569998.16178.35.camel@citrix.com> (raw)
In-Reply-To: <20151026105248.GR5060@zion.uk.xensource.com>
On Mon, 2015-10-26 at 10:52 +0000, Wei Liu wrote:
> On Fri, Oct 23, 2015 at 04:44:11PM +0100, Ian Jackson wrote:
> > def_getopt would print a message to stderr, but blunder on anyway.
> >
> > Sadly this is probably not a backport candidate.
> >
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied.
>
> > ---
> > tools/libxl/xl_cmdimpl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index ea43761..de28593 100644
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -2759,6 +2759,7 @@ static int def_getopt(int argc, char * const
> > argv[],
> > exit(0);
> > }
> > fprintf(stderr, "option `%c' not supported.\n", optopt);
> > + exit(2);
> > }
> > if (opt == 'h') {
> > help(helpstr);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-11-03 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:44 [PATCH] xl: Die on unknown options Ian Jackson
2015-10-26 10:52 ` Wei Liu
2015-11-03 16:59 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446569998.16178.35.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.