From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2] xl: log an error if libxl_cpupool_destroy() fails
Date: Tue, 3 Nov 2015 17:08:26 +0000 [thread overview]
Message-ID: <1446570506.16178.44.camel@citrix.com> (raw)
In-Reply-To: <20151028165108.GB3760@zion.uk.xensource.com>
On Wed, 2015-10-28 at 16:51 +0000, Wei Liu wrote:
> On Wed, Oct 28, 2015 at 05:43:51PM +0100, Dario Faggioli wrote:
> > In fact, right now, failing at destroying a cpupool is just
> > not reported to the user in any explicit way.
> >
> > Let's log an error, as it is customary for xl in these cases.
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
This conflicted with the changes to use EXIT_(ERROR|SUCCESS). By changing
"return 0" into "return EXIT_SUCCESS" and "return 1" into "return
EXIT_ERROR" in the context it applied cleanly.
I was about to apply when I noticed the strange Reviewed-by: Jueregen
(having already spotted and fixed in the Cc). I don't think I want to apply
it like that. Please can you fix and rebase (after I push Harman's changes
soon) and resend.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-03 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 16:43 [PATCH v2] xl: log an error if libxl_cpupool_destroy() fails Dario Faggioli
2015-10-28 16:51 ` Wei Liu
2015-11-03 17:08 ` Ian Campbell [this message]
2015-11-03 17:11 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446570506.16178.44.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.