From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] xl: log an error if libxl_cpupool_destroy() fails Date: Tue, 3 Nov 2015 18:11:36 +0100 Message-ID: <1446570696.3829.66.camel@citrix.com> References: <20151028164351.16499.1030.stgit@Solace.station> <20151028165108.GB3760@zion.uk.xensource.com> <1446570506.16178.44.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2199317148567987818==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ztf7X-0007Rl-PM for xen-devel@lists.xenproject.org; Tue, 03 Nov 2015 17:11:43 +0000 In-Reply-To: <1446570506.16178.44.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Wei Liu Cc: Juergen Gross , xen-devel@lists.xenproject.org, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============2199317148567987818== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-nRq9FFVF+KsOdbSW9xRd" --=-nRq9FFVF+KsOdbSW9xRd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-11-03 at 17:08 +0000, Ian Campbell wrote: > On Wed, 2015-10-28 at 16:51 +0000, Wei Liu wrote: > > On Wed, Oct 28, 2015 at 05:43:51PM +0100, Dario Faggioli wrote: > > > In fact, right now, failing at destroying a cpupool is just > > > not reported to the user in any explicit way. > > >=20 > > > Let's log an error, as it is customary for xl in these cases. > > >=20 > > > Signed-off-by: Dario Faggioli > > > Reviewed-by: Juergen Gross > >=20 > > Acked-by: Wei Liu >=20 > This conflicted with the changes to use EXIT_(ERROR|SUCCESS). By > changing > "return 0" into "return EXIT_SUCCESS" and "return 1" into "return > EXIT_ERROR" in the context it applied cleanly.=20 >=20 Right, thanks for trying. > I was about to apply when I noticed the strange Reviewed-by: Jueregen > (having already spotted and fixed in the Cc). I don't think I want to > apply > it like that.=20 > Oh, come on! How the heck did I manage to put it in there like that, and to not notice it until now! :-( Anyway, sorry for wasting your time. > Please can you fix and rebase (after I push Harman's changes > soon) and resend. >=20 Sure thing. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-nRq9FFVF+KsOdbSW9xRd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlY46skACgkQk4XaBE3IOsQKuACfYDlqtOhtIh+mfz/yRRxkLa3J gjoAmweHQkINllO8j7JzYsZGQvQMew+p =ewD+ -----END PGP SIGNATURE----- --=-nRq9FFVF+KsOdbSW9xRd-- --===============2199317148567987818== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2199317148567987818==--