All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: brking@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com,
	manoj@linux.vnet.ibm.com,
	Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Subject: [PATCH v2 2/5] ipr: Don't set NO_ULEN_CHK bit when resource is a vset.
Date: Tue,  3 Nov 2015 16:26:07 -0200	[thread overview]
Message-ID: <1446575170-18656-2-git-send-email-krisman@linux.vnet.ibm.com> (raw)
In-Reply-To: <1446575170-18656-1-git-send-email-krisman@linux.vnet.ibm.com>

According to the IPR specification, Inhibit Underlength Checking bit
must be disabled when issuing commands to vsets.  Enabling it in this
case might cause SCSI commands to fail with an Illegal Request, so make
sure we keep this bit cleared when resource is a vset.

Changes since v1:
	- Put gsci exclusive stuff in a separate block.

Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
---
 drivers/scsi/ipr.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 238efab..6849b7f 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -6363,15 +6363,19 @@ static int ipr_queuecommand(struct Scsi_Host *shost,
 	ipr_cmd->scsi_cmd = scsi_cmd;
 	ipr_cmd->done = ipr_scsi_eh_done;
 
-	if (ipr_is_gscsi(res) || ipr_is_vset_device(res)) {
+	if (ipr_is_gscsi(res)) {
 		if (scsi_cmd->underflow == 0)
 			ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_ULEN_CHK;
 
-		ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_LINK_DESC;
-		if (ipr_is_gscsi(res) && res->reset_occurred) {
+		if (res->reset_occurred) {
 			res->reset_occurred = 0;
 			ioarcb->cmd_pkt.flags_lo |= IPR_FLAGS_LO_DELAY_AFTER_RST;
 		}
+	}
+
+	if (ipr_is_gscsi(res) || ipr_is_vset_device(res)) {
+		ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_LINK_DESC;
+
 		ioarcb->cmd_pkt.flags_lo |= IPR_FLAGS_LO_ALIGNED_BFR;
 		if (scsi_cmd->flags & SCMD_TAGGED)
 			ioarcb->cmd_pkt.flags_lo |= IPR_FLAGS_LO_SIMPLE_TASK;
-- 
2.1.0


  reply	other threads:[~2015-11-03 18:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 18:26 [PATCH v2 1/5] ipr: Add delay to ensure coherent dumps Gabriel Krisman Bertazi
2015-11-03 18:26 ` Gabriel Krisman Bertazi [this message]
2015-11-03 20:39   ` [PATCH v2 2/5] ipr: Don't set NO_ULEN_CHK bit when resource is a vset Manoj Kumar
2015-11-04  2:52   ` Brian King
2015-11-04 18:50   ` wenxiong
2015-11-03 18:26 ` [PATCH v2 3/5] ipr: Inquiry IOA page 0xC4 during initialization Gabriel Krisman Bertazi
2015-11-04  2:53   ` Brian King
2015-11-04 18:51   ` wenxiong
2015-11-03 18:26 ` [PATCH v2 4/5] ipr: Issue Configure Cache Parameters command Gabriel Krisman Bertazi
2015-11-04  2:53   ` Brian King
2015-11-04 18:52   ` wenxiong
2015-11-03 18:26 ` [PATCH v2 5/5] ipr: Driver version 2.6.3 Gabriel Krisman Bertazi
2015-11-04  2:53   ` Brian King
2015-11-04 18:51   ` wenxiong
2015-11-04  2:52 ` [PATCH v2 1/5] ipr: Add delay to ensure coherent dumps Brian King
2015-11-04 18:51 ` wenxiong
2015-11-10  0:34 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446575170-18656-2-git-send-email-krisman@linux.vnet.ibm.com \
    --to=krisman@linux.vnet.ibm.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manoj@linux.vnet.ibm.com \
    --cc=wenxiong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.