* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level @ 2015-11-03 19:35 Jacob Keller 2015-11-03 22:40 ` Allan, Bruce W 2015-11-09 23:06 ` Singh, Krishneil K 0 siblings, 2 replies; 8+ messages in thread From: Jacob Keller @ 2015-11-03 19:35 UTC (permalink / raw) To: intel-wired-lan From: Bruce Allan <bruce.w.allan@intel.com> Cleans up checkpatch GLOBAL_INITIALIZERS error Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> --- -v2 * Fix title from checkpatch complaint drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c index e13d0fe1f17f..03607ecf0653 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c @@ -42,7 +42,7 @@ MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION); /* single workqueue for entire fm10k driver */ -struct workqueue_struct *fm10k_workqueue = NULL; +struct workqueue_struct *fm10k_workqueue; /** * fm10k_init_module - Driver Registration Routine @@ -56,8 +56,7 @@ static int __init fm10k_init_module(void) pr_info("%s\n", fm10k_copyright); /* create driver workqueue */ - if (!fm10k_workqueue) - fm10k_workqueue = create_workqueue("fm10k"); + fm10k_workqueue = create_workqueue("fm10k"); fm10k_dbg_init(); @@ -80,7 +79,6 @@ static void __exit fm10k_exit_module(void) /* destroy driver workqueue */ flush_workqueue(fm10k_workqueue); destroy_workqueue(fm10k_workqueue); - fm10k_workqueue = NULL; } module_exit(fm10k_exit_module); -- 2.6.1.264.gbab76a9 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 19:35 [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level Jacob Keller @ 2015-11-03 22:40 ` Allan, Bruce W 2015-11-03 23:05 ` Keller, Jacob E 2015-11-09 23:06 ` Singh, Krishneil K 1 sibling, 1 reply; 8+ messages in thread From: Allan, Bruce W @ 2015-11-03 22:40 UTC (permalink / raw) To: intel-wired-lan > -----Original Message----- > From: Keller, Jacob E > Sent: Tuesday, November 03, 2015 11:35 AM > To: Intel Wired LAN > Cc: Allan, Bruce W; Keller, Jacob E > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level > > From: Bruce Allan <bruce.w.allan@intel.com> > > Cleans up checkpatch GLOBAL_INITIALIZERS error > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > --- > -v2 > * Fix title from checkpatch complaint Out of curiosity, what was wrong with the original v1 patch title and what was the exact checkpatch complaint? ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 22:40 ` Allan, Bruce W @ 2015-11-03 23:05 ` Keller, Jacob E 2015-11-03 23:15 ` Allan, Bruce W 0 siblings, 1 reply; 8+ messages in thread From: Keller, Jacob E @ 2015-11-03 23:05 UTC (permalink / raw) To: intel-wired-lan On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote: > > -----Original Message----- > > From: Keller, Jacob E > > Sent: Tuesday, November 03, 2015 11:35 AM > > To: Intel Wired LAN > > Cc: Allan, Bruce W; Keller, Jacob E > > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > global level > > > > From: Bruce Allan <bruce.w.allan@intel.com> > > > > Cleans up checkpatch GLOBAL_INITIALIZERS error > > > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > > --- > > -v2 > > * Fix title from checkpatch complaint > > Out of curiosity, what was wrong with the original v1 patch title and > what was the exact checkpatch complaint? > checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error" WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it #4: Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error total: 0 errors, 1 warnings, 0 checks, 24 lines checked Regards, Jake ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 23:05 ` Keller, Jacob E @ 2015-11-03 23:15 ` Allan, Bruce W 2015-11-03 23:19 ` Keller, Jacob E 0 siblings, 1 reply; 8+ messages in thread From: Allan, Bruce W @ 2015-11-03 23:15 UTC (permalink / raw) To: intel-wired-lan > -----Original Message----- > From: Keller, Jacob E > Sent: Tuesday, November 03, 2015 3:05 PM > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue at global > level > > On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote: > > > -----Original Message----- > > > From: Keller, Jacob E > > > Sent: Tuesday, November 03, 2015 11:35 AM > > > To: Intel Wired LAN > > > Cc: Allan, Bruce W; Keller, Jacob E > > > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > > global level > > > > > > From: Bruce Allan <bruce.w.allan@intel.com> > > > > > > Cleans up checkpatch GLOBAL_INITIALIZERS error > > > > > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> > > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > > > --- > > > -v2 > > > * Fix title from checkpatch complaint > > > > Out of curiosity, what was wrong with the original v1 patch title and > > what was the exact checkpatch complaint? > > > > checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch > GLOBAL_INITIALISERS error" > > WARNING:EMAIL_SUBJECT: A patch subject line should describe the change > not the tool that found it > #4: > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > > > Regards, > Jake Which version of checkpatch and options did you use? I tried with the one in Jeff's tree and others but do not get the same. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 23:15 ` Allan, Bruce W @ 2015-11-03 23:19 ` Keller, Jacob E 2015-11-03 23:22 ` Allan, Bruce W 0 siblings, 1 reply; 8+ messages in thread From: Keller, Jacob E @ 2015-11-03 23:19 UTC (permalink / raw) To: intel-wired-lan On Tue, 2015-11-03 at 23:15 +0000, Allan, Bruce W wrote: > > -----Original Message----- > > From: Keller, Jacob E > > Sent: Tuesday, November 03, 2015 3:05 PM > > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org > > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > global > > level > > > > On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote: > > > > -----Original Message----- > > > > From: Keller, Jacob E > > > > Sent: Tuesday, November 03, 2015 11:35 AM > > > > To: Intel Wired LAN > > > > Cc: Allan, Bruce W; Keller, Jacob E > > > > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > > > global level > > > > > > > > From: Bruce Allan <bruce.w.allan@intel.com> > > > > > > > > Cleans up checkpatch GLOBAL_INITIALIZERS error > > > > > > > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> > > > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > > > > --- > > > > -v2 > > > > * Fix title from checkpatch complaint > > > > > > Out of curiosity, what was wrong with the original v1 patch title > > > and > > > what was the exact checkpatch complaint? > > > > > > > checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch > > GLOBAL_INITIALISERS error" > > > > WARNING:EMAIL_SUBJECT: A patch subject line should describe the > > change > > not the tool that found it > > #4: > > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error > > > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > > > > > > Regards, > > Jake > > Which version of checkpatch and options did you use? I tried with > the one in Jeff's tree and others but do not get the same. The one in Jeff's tree did it for me, and has been since commit a2fe16b9d878 ("checkpatch: try to avoid poor patch subject lines") I get: WARNING: A patch subject line should describe the change not the tool that found it #4: Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error total: 0 errors, 1 warnings, 0 checks, 24 lines checked Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Regards, Jake ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 23:19 ` Keller, Jacob E @ 2015-11-03 23:22 ` Allan, Bruce W 2015-11-03 23:31 ` Keller, Jacob E 0 siblings, 1 reply; 8+ messages in thread From: Allan, Bruce W @ 2015-11-03 23:22 UTC (permalink / raw) To: intel-wired-lan > -----Original Message----- > From: Keller, Jacob E > Sent: Tuesday, November 03, 2015 3:20 PM > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue at global > level > > On Tue, 2015-11-03 at 23:15 +0000, Allan, Bruce W wrote: > > > -----Original Message----- > > > From: Keller, Jacob E > > > Sent: Tuesday, November 03, 2015 3:05 PM > > > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org > > > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > > global > > > level > > > > > > On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote: > > > > > -----Original Message----- > > > > > From: Keller, Jacob E > > > > > Sent: Tuesday, November 03, 2015 11:35 AM > > > > > To: Intel Wired LAN > > > > > Cc: Allan, Bruce W; Keller, Jacob E > > > > > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > > > > global level > > > > > > > > > > From: Bruce Allan <bruce.w.allan@intel.com> > > > > > > > > > > Cleans up checkpatch GLOBAL_INITIALIZERS error > > > > > > > > > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> > > > > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > > > > > --- > > > > > -v2 > > > > > * Fix title from checkpatch complaint > > > > > > > > Out of curiosity, what was wrong with the original v1 patch title > > > > and > > > > what was the exact checkpatch complaint? > > > > > > > > > > checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch > > > GLOBAL_INITIALISERS error" > > > > > > WARNING:EMAIL_SUBJECT: A patch subject line should describe the > > > change > > > not the tool that found it > > > #4: > > > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error > > > > > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > > > > > > > > > Regards, > > > Jake > > > > Which version of checkpatch and options did you use? I tried with > > the one in Jeff's tree and others but do not get the same. > > > The one in Jeff's tree did it for me, and has been since commit > > a2fe16b9d878 ("checkpatch: try to avoid poor patch subject lines") > > I get: > > > WARNING: A patch subject line should describe the change not the tool that > found it > #4: > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > > Your patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > > Regards, > Jake Very odd, since it seems we are doing the same thing but get different results :( ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 23:22 ` Allan, Bruce W @ 2015-11-03 23:31 ` Keller, Jacob E 0 siblings, 0 replies; 8+ messages in thread From: Keller, Jacob E @ 2015-11-03 23:31 UTC (permalink / raw) To: intel-wired-lan On Tue, 2015-11-03 at 23:22 +0000, Allan, Bruce W wrote: > > -----Original Message----- > > From: Keller, Jacob E > > Sent: Tuesday, November 03, 2015 3:20 PM > > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org > > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue at > > global > > level > > > > On Tue, 2015-11-03 at 23:15 +0000, Allan, Bruce W wrote: > > > > -----Original Message----- > > > > From: Keller, Jacob E > > > > Sent: Tuesday, November 03, 2015 3:05 PM > > > > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org > > > > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue > > > > at > > > > global > > > > level > > > > > > > > On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote: > > > > > > -----Original Message----- > > > > > > From: Keller, Jacob E > > > > > > Sent: Tuesday, November 03, 2015 11:35 AM > > > > > > To: Intel Wired LAN > > > > > > Cc: Allan, Bruce W; Keller, Jacob E > > > > > > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue > > > > > > at > > > > > > global level > > > > > > > > > > > > From: Bruce Allan <bruce.w.allan@intel.com> > > > > > > > > > > > > Cleans up checkpatch GLOBAL_INITIALIZERS error > > > > > > > > > > > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> > > > > > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > > > > > > --- > > > > > > -v2 > > > > > > * Fix title from checkpatch complaint > > > > > > > > > > Out of curiosity, what was wrong with the original v1 patch > > > > > title > > > > > and > > > > > what was the exact checkpatch complaint? > > > > > > > > > > > > > checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch > > > > GLOBAL_INITIALISERS error" > > > > > > > > WARNING:EMAIL_SUBJECT: A patch subject line should describe the > > > > change > > > > not the tool that found it > > > > #4: > > > > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS > > > > error > > > > > > > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > > > > > > > > > > > > Regards, > > > > Jake > > > > > > Which version of checkpatch and options did you use? I tried > > > with > > > the one in Jeff's tree and others but do not get the same. > > > > > > The one in Jeff's tree did it for me, and has been since commit > > > > a2fe16b9d878 ("checkpatch: try to avoid poor patch subject lines") > > > > I get: > > > > > > WARNING: A patch subject line should describe the change not the > > tool that > > found it > > #4: > > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error > > > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > > > > Your patch has style problems, please review. > > > > NOTE: If any of the errors are false positives, please report > > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > > > > > Regards, > > Jake > > Very odd, since it seems we are doing the same thing but get > different results :( Do: $git ls-tree HEAD scripts/checkpatch.pl What is the output you get? I get: 100755 blob f2a1131b2f8baf06f28e286d6b9203d4d1a873f6 scripts/checkpatch.pl If you get the same sha1, then we should ensure we're checking the same commit output. I ran the following commit from my reflog into checkpatch: 4917fe7bef67 ("fm10k: fix checkpatch GLOBAL_INITIALISERS error") which I have also attached to this email in format patch format. Is it possible you're only showing the contents of the diff and not the actual subject header? This checkpatch warning won't show up if you don't pass it a full commit data and only pass it a diff. Regards, Jake -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-fm10k-fix-checkpatch-GLOBAL_INITIALISERS-error.patch Type: text/x-patch Size: 1492 bytes Desc: 0001-fm10k-fix-checkpatch-GLOBAL_INITIALISERS-error.patch URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151103/e19c9f75/attachment.bin> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level 2015-11-03 19:35 [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level Jacob Keller 2015-11-03 22:40 ` Allan, Bruce W @ 2015-11-09 23:06 ` Singh, Krishneil K 1 sibling, 0 replies; 8+ messages in thread From: Singh, Krishneil K @ 2015-11-09 23:06 UTC (permalink / raw) To: intel-wired-lan -----Original Message----- From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller Sent: Tuesday, November 3, 2015 11:35 AM To: Intel Wired LAN <intel-wired-lan@lists.osuosl.org> Subject: [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level From: Bruce Allan <bruce.w.allan@intel.com> Cleans up checkpatch GLOBAL_INITIALIZERS error Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> --- Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-11-09 23:06 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-03 19:35 [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level Jacob Keller 2015-11-03 22:40 ` Allan, Bruce W 2015-11-03 23:05 ` Keller, Jacob E 2015-11-03 23:15 ` Allan, Bruce W 2015-11-03 23:19 ` Keller, Jacob E 2015-11-03 23:22 ` Allan, Bruce W 2015-11-03 23:31 ` Keller, Jacob E 2015-11-09 23:06 ` Singh, Krishneil K
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.