From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 2/6] xen: sched: fix locking for insert_vcpu() in credit1 and RTDS Date: Wed, 4 Nov 2015 15:12:55 +0100 Message-ID: <1446646375.3829.108.camel@citrix.com> References: <20151029225158.25219.4625.stgit@Solace.station> <20151029230420.25219.74544.stgit@Solace.station> <1446451425.2750.3.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8338601115511250328==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZtyoU-0001Ta-1c for xen-devel@lists.xenproject.org; Wed, 04 Nov 2015 14:13:22 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu Cc: George Dunlap , "xen-devel@lists.xenproject.org" , Meng Xu List-Id: xen-devel@lists.xenproject.org --===============8338601115511250328== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-8xfSeR6fd3RpFouASTIR" --=-8xfSeR6fd3RpFouASTIR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-11-02 at 09:45 -0500, Meng Xu wrote: > > > I guess maybe you forgot to change it in this commit but change > > > it > > > the > > > following commit? > > >=20 > > No, this is one of the few thing that changed between v2 and v3. > >=20 > > Regards, > > Dario >=20 > Thanks for the explanation! Then the patch looks good to me, at least > for RTDS scheduler. :-) >=20 Thanks for looking at the patch. Just FTR (and for next time :-D), is the above something that can be interpreted as a 'Reviewed-by: Meng Xu ' ? If no (e.g., because you haven't looking thoroughly enough to feel confident to express it), then fine, I was just asking. If yes, I encourage you to say it explicitly, to avoid errors and misjudgements. If you 'only' looked at the patch with the RTDS scheduler in mind, that is fine too. You can say something like "As far as the RTDS scheduler is concerned: Reviewed-by: Meng Xu ". Other reviewers and committers will take this into account and properly weight it. Every akc/review is important, and, if you took the time to look at a patch, why don't say it in the proper way? :-) I'm about to send v4 of this series. Feel free (only if you want, of course!), to chime in in that thread. Thanks again and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-8xfSeR6fd3RpFouASTIR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlY6EmcACgkQk4XaBE3IOsTCeACbBYUmm6xSjxAgdL+elRTBcWUV IMcAni/d2qFjPjYpWm7tpj9DUXzwpIbI =rs8k -----END PGP SIGNATURE----- --=-8xfSeR6fd3RpFouASTIR-- --===============8338601115511250328== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8338601115511250328==--