From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xl: avoid (another) uninitialised use of rc in vcpuset() Date: Wed, 4 Nov 2015 15:28:33 +0000 Message-ID: <1446650913.6461.113.camel@citrix.com> References: <20151104120331.29313.40737.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZtzzN-0004l7-TJ for xen-devel@lists.xenproject.org; Wed, 04 Nov 2015 15:28:42 +0000 In-Reply-To: <20151104120331.29313.40737.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Wei Liu , Ian Jackson , Harmandeep Kaur List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE1LTExLTA0IGF0IDEzOjAzICswMTAwLCBEYXJpbyBGYWdnaW9saSB3cm90ZToK PiBSZWFyYW5nZSB0aGUgY2FzZSB3aGVuIHdlIGNoZWNrIHRoZSBuZXcgbnVtYmVyIG9mIHZDUFVz Cj4gYWdhaW5zdCB0aGUgbnVtYmVyIG9mIGhvc3QgcENQVXMgbm90IHRvIHVzZSByYyBmb3IgaW50 ZXJuYWwKPiBlcnJvciByZXBvcnRpbmcuIEluIGZhY3Q6Cj4gwqAtIHJjIHdhcyBhdCByaXNrIG9m IGJlaW5nIHVzZWQgdW5pbml0aWFsaXNlZDsKPiDCoC0gcmMgc2hvdWxkIG9ubHkgYmUgdXNlZCBm b3IgaG9sZGluZyBsaWJ4bCBlcnJvciBjb2Rlcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYXJpbyBG YWdnaW9saSA8ZGFyaW8uZmFnZ2lvbGlAY2l0cml4LmNvbT4KCmFja2VkICsgYXBwbGllZC4KCj4g LS0tCj4gQ2M6IElhbiBDYW1wYmVsbCA8aWFuLmNhbXBiZWxsQGNpdHJpeC5jb20+Cj4gQ2M6IElh biBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRyaXguY29tPgo+IENjOiBXZWkgTGl1IDx3ZWku bGl1MkBjaXRyaXguY29tPgo+IENjOiBIYXJtYW5kZWVwIEthdXIgPHdyaXRlLmhhcm1hbmRlZXBA Z21haWwuY29tPgo+IENjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t Pgo+IC0tLQo+IMKgdG9vbHMvbGlieGwveGxfY21kaW1wbC5jIHzCoMKgwqAxMiArKysrKystLS0t LS0KPiDCoDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYyBiL3Rvb2xzL2xpYnhsL3hs X2NtZGltcGwuYwo+IGluZGV4IDliNmI0MmMuLjc4MDQ4YTEgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMv bGlieGwveGxfY21kaW1wbC5jCj4gKysrIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCj4gQEAg LTU0NTcsMjEgKzU0NTcsMjEgQEAgc3RhdGljIGludCB2Y3B1c2V0KHVpbnQzMl90IGRvbWlkLCBj b25zdCBjaGFyKgo+IG5yX3ZjcHVzLCBpbnQgY2hlY2tfaG9zdCkKPiDCoMKgwqDCoMKgwqAqIGJ5 IHRoZSBob3N0J3MgYW1vdW50IG9mIHBDUFVzLgo+IMKgwqDCoMKgwqDCoCovCj4gwqDCoMKgwqDC oGlmIChjaGVja19ob3N0KSB7Cj4gLcKgwqDCoMKgwqDCoMKgwqB1bnNpZ25lZCBpbnQgaG9zdF9j cHUgPSBsaWJ4bF9nZXRfbWF4X2NwdXMoY3R4KTsKPiArwqDCoMKgwqDCoMKgwqDCoHVuc2lnbmVk IGludCBvbmxpbmVfdmNwdXMsIGhvc3RfY3B1ID0gbGlieGxfZ2V0X21heF9jcHVzKGN0eCk7Cj4g wqDCoMKgwqDCoMKgwqDCoMKgbGlieGxfZG9taW5mbyBkb21pbmZvOwo+IMKgCj4gwqDCoMKgwqDC oMKgwqDCoMKgaWYgKGxpYnhsX2RvbWFpbl9pbmZvKGN0eCwgJmRvbWluZm8sIGRvbWlkKSkKPiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAxOwo+IMKgCj4gLcKgwqDCoMKgwqDCoMKg wqBpZiAobWF4X3ZjcHVzID4gZG9taW5mby52Y3B1X29ubGluZSAmJiBtYXhfdmNwdXMgPiBob3N0 X2NwdSkgewo+ICvCoMKgwqDCoMKgwqDCoMKgb25saW5lX3ZjcHVzID0gZG9taW5mby52Y3B1X29u bGluZTsKPiArwqDCoMKgwqDCoMKgwqDCoGxpYnhsX2RvbWluZm9fZGlzcG9zZSgmZG9taW5mbyk7 Cj4gKwo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKG1heF92Y3B1cyA+IG9ubGluZV92Y3B1cyAmJiBt YXhfdmNwdXMgPiBob3N0X2NwdSkgewo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnByaW50 ZihzdGRlcnIsICJZb3UgYXJlIG92ZXJjb21tbWl0dGluZyEgWW91IGhhdmUgJWQKPiBwaHlzaWNh bCIgXAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCIgQ1BVcyBh bmQgd2FudCAlZCB2Q1BVcyEgQWJvcnRpbmcsIHVzZSAtLWlnbm9yZS0KPiBob3N0IHRvIiBcCj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIiBjb250aW51ZVxuIiwg aG9zdF9jcHUsIG1heF92Y3B1cyk7Cj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJjID0gMTsK PiAtwqDCoMKgwqDCoMKgwqDCoH0KPiAtwqDCoMKgwqDCoMKgwqDCoGxpYnhsX2RvbWluZm9fZGlz cG9zZSgmZG9taW5mbyk7Cj4gLcKgwqDCoMKgwqDCoMKgwqBpZiAocmMpCj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqByZXR1cm4gMTsKPiArwqDCoMKgwqDCoMKgwqDCoH0KPiDCoMKgwqDCoMKg fQo+IMKgwqDCoMKgwqByYyA9IGxpYnhsX2NwdV9iaXRtYXBfYWxsb2MoY3R4LCAmY3B1bWFwLCBt YXhfdmNwdXMpOwo+IMKgwqDCoMKgwqBpZiAocmMpIHsKPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK