From: Gerd Hoffmann <kraxel@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring
Date: Thu, 05 Nov 2015 09:37:47 +0100 [thread overview]
Message-ID: <1446712667.30393.8.camel@redhat.com> (raw)
In-Reply-To: <1446595225-23608-3-git-send-email-bsd@redhat.com>
> +#include <sys/inotify.h>
What happens on non-linux systems?
I guess we need some #ifdefs to not break the build there, or enable mtp
only for CONFIG_LINUX=y instead of CONFIG_POSIX=y.
> +enum inotify_event_type {
> + CREATE = 1,
> + DELETE = 2,
> + MODIFY = 3,
> +};
Patch #3 removes this, I'd suggest to extent "enum mtp_code" with the
event codes here so we don't need this temporary thing.
cheers,
Gerd
next prev parent reply other threads:[~2015-11-05 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 0:00 [Qemu-devel] [PATCH 0/3] usb-mtp events support Bandan Das
2015-11-04 0:00 ` [Qemu-devel] [PATCH 1/3] usb-mtp: use a list for keeping track of children Bandan Das
2015-11-05 8:24 ` Gerd Hoffmann
2015-11-05 21:23 ` Bandan Das
2015-11-04 0:00 ` [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring Bandan Das
2015-11-05 8:37 ` Gerd Hoffmann [this message]
2015-11-05 21:28 ` Bandan Das
2015-11-05 8:49 ` Gerd Hoffmann
2015-11-09 23:12 ` Bandan Das
2015-11-09 23:28 ` Bandan Das
2015-11-12 8:16 ` Gerd Hoffmann
2015-11-12 22:40 ` Bandan Das
2015-11-13 8:08 ` Gerd Hoffmann
2015-11-05 8:49 ` Gerd Hoffmann
2015-11-09 23:13 ` Bandan Das
2015-11-04 0:00 ` [Qemu-devel] [PATCH 3/3] usb-mtp: add support for basic mtp events Bandan Das
2015-11-05 8:41 ` Gerd Hoffmann
2015-11-05 21:30 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446712667.30393.8.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=bsd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.