All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, John Snow <jsnow@redhat.com>,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage
Date: Thu,  5 Nov 2015 18:53:01 -0500	[thread overview]
Message-ID: <1446767584-13132-1-git-send-email-jsnow@redhat.com> (raw)

cvtnum returns an int64_t, not an int, so correct the lvalue types
wherever it is used. While we're at it, make the error messages more
meaningful and hopefully less confusing.

v4:
 - Now missing ALL sweaters

v3:
 - pulled a lot of loose yarn, now missing my sweater
   (Updated patch 1 even further, reported-by Kevin)

v2:
 - Squashed NSIG error-checking from patch 3 into patch 1
 - Reported-by credits for Max and Reviewed-by from Eric added

________________________________________________________________________________

For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch qemu-io-tidy
https://github.com/jnsnow/qemu/tree/qemu-io-tidy

This version is tagged qemu-io-tidy-v4:
https://github.com/jnsnow/qemu/releases/tag/qemu-io-tidy-v4

John Snow (3):
  qemu-io: fix cvtnum lval types
  qemu-io: Check for trailing chars
  qemu-io: Correct error messages

 qemu-io-cmds.c | 185 ++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 129 insertions(+), 56 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-11-05 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 23:53 John Snow [this message]
2015-11-05 23:53 ` [Qemu-devel] [PATCH v4 1/3] qemu-io: fix cvtnum lval types John Snow
2015-11-05 23:53 ` [Qemu-devel] [PATCH v4 2/3] qemu-io: Check for trailing chars John Snow
2015-11-05 23:53 ` [Qemu-devel] [PATCH v4 3/3] qemu-io: Correct error messages John Snow
2015-11-06  9:46 ` [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage Kevin Wolf
2015-11-06 19:01   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446767584-13132-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.