From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] topology: Include in API header file Date: Fri, 06 Nov 2015 14:57:17 +0000 Message-ID: <1446821837.2776.27.camel@loki> References: <1446813576-29295-1-git-send-email-mengdong.lin@linux.intel.com> <20151106133118.GA18120@localhost> <1446820647.2776.19.camel@loki> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by alsa0.perex.cz (Postfix) with ESMTP id E17A3260438 for ; Fri, 6 Nov 2015 15:57:46 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com, Vinod Koul , mengdong.lin@intel.com, broonie@kernel.org, subhransu.s.prusty@intel.com List-Id: alsa-devel@alsa-project.org On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote: > On Fri, 06 Nov 2015 15:37:27 +0100, > Liam Girdwood wrote: > > > > > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 > > From: Liam Girdwood > > Date: Fri, 6 Nov 2015 14:30:36 +0000 > > Subject: [PATCH] topology: remove little endian type from userspace header. > > > > Use a generic unsigned long long for formats instead of an ABI endian > > specific __le64 type. > > Or use uint64_t instead. This is the standard definition of 64bit > integer. I thought we already include stdint.h somewhere, but you can > included it there again to be sure, too. > I didn't see stdint.h so used unsigned long long on the first patch. The patch below fixes this though :- >>From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001 From: Liam Girdwood Date: Fri, 6 Nov 2015 14:30:36 +0000 Subject: [PATCH] topology: remove little endian type from userspace header. Use a generic uint64_t for formats instead of an ABI endian specific __le64 type. Signed-off-by: Liam Girdwood --- include/topology.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/topology.h b/include/topology.h index b631871..993537c 100644 --- a/include/topology.h +++ b/include/topology.h @@ -21,6 +21,8 @@ #ifndef __ALSA_TOPOLOGY_H #define __ALSA_TOPOLOGY_H +#include + #ifdef __cplusplus extern "C" { #endif @@ -665,7 +667,7 @@ struct snd_tplg_stream_template { */ struct snd_tplg_stream_caps_template { const char *name; /*!< name of the stream caps */ - __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ + uint64_t formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ unsigned int rates; /*!< supported rates SNDRV_PCM_RATE_* */ unsigned int rate_min; /*!< min rate */ unsigned int rate_max; /*!< max rate */ -- 2.5.0