From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: abel@uni-bielefeld.de
Cc: poky@yoctoproject.org
Subject: Re: Patch.bbclass URL Reasoning
Date: Tue, 27 Mar 2012 14:05:59 +0100 [thread overview]
Message-ID: <1447035.Hxb8yfX2az@helios> (raw)
In-Reply-To: <4F71B96F.5020409@uni-bielefeld.de>
On Tuesday 27 March 2012 14:58:23 Robert Abel wrote:
> On 27.03.2012 14:55, Paul Eggleton wrote:
> > However if I needed to do what you want to do I would do it differently -
> > instead of modifying the patches, why not just modify the file(s) in the
> > source code directly? I would suggest using sed in a
> > do_configure_prepend() to change the values in the source to the desired
> > value from a variable. Depending on the complexity you could have the
> > patches change the values to some easily replaceable string beforehand.
>
> That's exactly what I'm doing right now. However, since I'm patching the
> kernel and users could theoretically add patches containing my magic
> strings, I wanted to avoid a sed on git\* and instead only edit *.patch
> in ${WORKDIR}, which is why I'm asking why the copied patches go unused.
Well, I can't answer that, but I don't think it's too difficult to come up with
a string that's unlikely to ever occur in the kernel sources.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-27 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 12:41 Patch.bbclass URL Reasoning Robert Abel
2012-03-27 12:55 ` Paul Eggleton
[not found] ` <4F71B96F.5020409@uni-bielefeld.de>
2012-03-27 13:05 ` Paul Eggleton [this message]
2012-03-27 13:25 ` Bruce Ashfield
-- strict thread matches above, loose matches on Subject: below --
2012-03-21 17:18 Robert Abel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447035.Hxb8yfX2az@helios \
--to=paul.eggleton@linux.intel.com \
--cc=abel@uni-bielefeld.de \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.