All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Taeung Song <treeze.taeung@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH v10 01/22] perf tools: Add 'perf-config' command
Date: Mon,  9 Nov 2015 11:32:54 +0900	[thread overview]
Message-ID: <1447036395-18911-2-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1447036395-18911-1-git-send-email-treeze.taeung@gmail.com>

The perf configuration file contains many variables to change various
aspects of each of its tools, including output, disk usage, etc.
But looking through state of configuration is difficult and
there's no knowing what kind of other variables except variables
in perfconfig.example exist. So This patch adds 'perf-config'
command with '--list' option.

    perf config [options]

    display current perf config variables.
    # perf config
    or
    # perf config -l | --list

Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/Build            |  1 +
 tools/perf/builtin-config.c | 61 +++++++++++++++++++++++++++++++++++++++++++++
 tools/perf/builtin.h        |  1 +
 tools/perf/command-list.txt |  1 +
 tools/perf/perf.c           |  1 +
 5 files changed, 65 insertions(+)
 create mode 100644 tools/perf/builtin-config.c

diff --git a/tools/perf/Build b/tools/perf/Build
index 7223745..2c7aaf2 100644
--- a/tools/perf/Build
+++ b/tools/perf/Build
@@ -1,5 +1,6 @@
 perf-y += builtin-bench.o
 perf-y += builtin-annotate.o
+perf-y += builtin-config.o
 perf-y += builtin-diff.o
 perf-y += builtin-evlist.o
 perf-y += builtin-help.o
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
new file mode 100644
index 0000000..2d16150
--- /dev/null
+++ b/tools/perf/builtin-config.c
@@ -0,0 +1,61 @@
+/*
+ * builtin-config.c
+ *
+ * Copyright (C) 2015, Taeung Song <treeze.taeung@gmail.com>
+ *
+ */
+#include "builtin.h"
+
+#include "perf.h"
+
+#include "util/cache.h"
+#include "util/parse-options.h"
+#include "util/util.h"
+#include "util/debug.h"
+
+static const char * const config_usage[] = {
+	"perf config [options]",
+	NULL
+};
+
+enum actions {
+	ACTION_LIST = 1
+} actions;
+
+static struct option config_options[] = {
+	OPT_SET_UINT('l', "list", &actions,
+		     "show current config variables", ACTION_LIST),
+	OPT_END()
+};
+
+static int show_config(const char *key, const char *value,
+		       void *cb __maybe_unused)
+{
+	if (value)
+		printf("%s=%s\n", key, value);
+	else
+		printf("%s\n", key);
+
+	return 0;
+}
+
+int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
+{
+	int ret = 0;
+
+	argc = parse_options(argc, argv, config_options, config_usage,
+			     PARSE_OPT_STOP_AT_NON_OPTION);
+
+	switch (actions) {
+	case ACTION_LIST:
+	default:
+		if (argc) {
+			pr_err("Error: takes no arguments\n");
+			parse_options_usage(config_usage, config_options, "l", 1);
+			return -1;
+		} else
+			ret = perf_config(show_config, NULL);
+	}
+
+	return ret;
+}
diff --git a/tools/perf/builtin.h b/tools/perf/builtin.h
index 3688ad2..3f871b5 100644
--- a/tools/perf/builtin.h
+++ b/tools/perf/builtin.h
@@ -17,6 +17,7 @@ extern int cmd_annotate(int argc, const char **argv, const char *prefix);
 extern int cmd_bench(int argc, const char **argv, const char *prefix);
 extern int cmd_buildid_cache(int argc, const char **argv, const char *prefix);
 extern int cmd_buildid_list(int argc, const char **argv, const char *prefix);
+extern int cmd_config(int argc, const char **argv, const char *prefix);
 extern int cmd_diff(int argc, const char **argv, const char *prefix);
 extern int cmd_evlist(int argc, const char **argv, const char *prefix);
 extern int cmd_help(int argc, const char **argv, const char *prefix);
diff --git a/tools/perf/command-list.txt b/tools/perf/command-list.txt
index 00fcaf8..acc3ea7 100644
--- a/tools/perf/command-list.txt
+++ b/tools/perf/command-list.txt
@@ -9,6 +9,7 @@ perf-buildid-cache		mainporcelain common
 perf-buildid-list		mainporcelain common
 perf-data			mainporcelain common
 perf-diff			mainporcelain common
+perf-config			mainporcelain common
 perf-evlist			mainporcelain common
 perf-inject			mainporcelain common
 perf-kmem			mainporcelain common
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 3d4c7c0..4bee53c 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -39,6 +39,7 @@ struct cmd_struct {
 static struct cmd_struct commands[] = {
 	{ "buildid-cache", cmd_buildid_cache, 0 },
 	{ "buildid-list", cmd_buildid_list, 0 },
+	{ "config",	cmd_config,	0 },
 	{ "diff",	cmd_diff,	0 },
 	{ "evlist",	cmd_evlist,	0 },
 	{ "help",	cmd_help,	0 },
-- 
1.9.1


  reply	other threads:[~2015-11-09  2:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09  2:32 [PATCH v10 00/22] perf tools: Add 'perf-config' command Taeung Song
2015-11-09  2:32 ` Taeung Song [this message]
2015-11-09 13:58   ` [PATCH v10 01/22] " Arnaldo Carvalho de Melo
2015-11-09 14:02     ` Arnaldo Carvalho de Melo
2015-11-09  2:32 ` [PATCH v10 02/22] perf tools: Add perf-config document Taeung Song
2015-11-09  2:32 ` [PATCH v10 03/22] perf config: Document variables for 'color' section in man page Taeung Song
2015-11-09  2:32 ` [PATCH v10 04/22] perf config: Document variables for 'tui' and 'gtk' sections " Taeung Song
2015-11-09  2:32 ` [PATCH v10 05/22] perf config: Document 'buildid.dir' variable " Taeung Song
2015-11-09  2:32 ` [PATCH v10 06/22] perf config: Document variables for 'annotate' section " Taeung Song
2015-11-09  2:33 ` [PATCH v10 07/22] perf config: Document variables for 'help' " Taeung Song
2015-11-09  2:33 ` [PATCH v10 08/22] perf config: Document 'hist.percentage' variable " Taeung Song
2015-11-09  2:33 ` [PATCH v10 09/22] perf config: Document 'ui.show-headers' " Taeung Song
2015-11-09  2:33 ` [PATCH v10 10/22] perf config: Document variables for 'call-graph' section " Taeung Song
2015-11-09  2:33 ` [PATCH v10 11/22] perf config: Document variables for 'report' " Taeung Song
2015-11-09  2:33 ` [PATCH v10 12/22] perf config: Document 'top.chidren' variable " Taeung Song
2015-11-09  2:33 ` [PATCH v10 13/22] perf config: Document 'man.viewer' " Taeung Song
2015-11-09  2:33 ` [PATCH v10 14/22] perf config: Document 'pager.<subcommand>' variables " Taeung Song
2015-11-09  2:33 ` [PATCH v10 15/22] perf config: Document 'kmem.default' variable " Taeung Song
2015-11-09  2:33 ` [PATCH v10 16/22] perf config: Add '--system' and '--user' options to select which config file is used Taeung Song
2015-11-09  2:33 ` [PATCH v10 17/22] perf config: Collect configs to handle config variables Taeung Song
2015-11-09  2:33 ` [PATCH v10 18/22] perf config: Add 'list-all' option to perf-config Taeung Song
2015-11-09  2:33 ` [PATCH v10 19/22] perf config: Add 'get' functionaliy Taeung Song
2015-11-09  2:33 ` [PATCH v10 20/22] perf config: Add 'set' feature Taeung Song
2015-11-09  2:33 ` [PATCH v10 21/22] perf config: normalize a value depending on default type of it Taeung Song
2015-11-09  2:33 ` [PATCH v10 22/22] perf config: Add a option 'remove' to perf-config Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447036395-18911-2-git-send-email-treeze.taeung@gmail.com \
    --to=treeze.taeung@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.