From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>
Cc: samueltan@google.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: clarify NL80211_ATTR_SCHED_SCAN_DELAY usage with net-detect
Date: Mon, 09 Nov 2015 11:14:29 +0100 [thread overview]
Message-ID: <1447064069.2428.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1447063916-338-1-git-send-email-luca@coelho.fi>
On Mon, 2015-11-09 at 12:11 +0200, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
>
> In this attribute's documentation, it was not clear whether the delay
> started counting when WoWLAN net-detect was enabled or when the
> system
> was suspended. The correct answer is that it starts when the system
> suspends (which is when, in practice, the scan is
> scheduled). Clarify
> that in the nl80211.h documentation.
>
> Suggested-by: Samuel Tan <samueltan@google.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> include/uapi/linux/nl80211.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/nl80211.h
> b/include/uapi/linux/nl80211.h
> index 1f0b4cf..ea24d66 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -1764,8 +1764,9 @@ enum nl80211_commands {
> * over all channels.
> *
> * @NL80211_ATTR_SCHED_SCAN_DELAY: delay before the first cycle of a
> - * scheduled scan (or a WoWLAN net-detect scan) is started,
> u32
> - * in seconds.
> + * scheduled scan is started. Or the dealy before a WoWLAN
> + * net-detect scan is started, counting from the moment the
> + * system is suspended. This value is a u32, in seconds.
>
delay :)
johannes
prev parent reply other threads:[~2015-11-09 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 10:11 [PATCH] nl80211: clarify NL80211_ATTR_SCHED_SCAN_DELAY usage with net-detect Luca Coelho
2015-11-09 10:14 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447064069.2428.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=samueltan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.