All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: yocto@yoctoproject.org
Cc: paul.eggleton@linux.intel.com
Subject: [PATCH 02/10][AUH] upgradehelper.py: Fix bug when buildhistory isn't enabled
Date: Mon,  9 Nov 2015 16:01:33 -0600	[thread overview]
Message-ID: <1447106501-470-3-git-send-email-anibal.limon@linux.intel.com> (raw)
In-Reply-To: <1447106501-470-1-git-send-email-anibal.limon@linux.intel.com>

Don't use buildhistory object if buildhistory_enabled is False
because cause undefined variable error.

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
 upgradehelper.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/upgradehelper.py b/upgradehelper.py
index bb19b65..9b321f6 100755
--- a/upgradehelper.py
+++ b/upgradehelper.py
@@ -310,7 +310,7 @@ class Updater(object):
         for machine in self.machines:
             I(" %s: compiling for %s ..." % (self.pn, machine))
             self.recipe.compile(machine)
-            if self.buildhistory is not None:
+            if self.buildhistory_enabled == True:
                 self.buildhistory.add()
 
     def _buildhistory_diff(self):
-- 
2.1.4



  parent reply	other threads:[~2015-11-09 22:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 22:01 [PATCH 00/10][AUH] Improvements and small fixes Aníbal Limón
2015-11-09 22:01 ` [PATCH 01/10][AUH] upgradehelper.py: Add step for build gcc-runtime at init Aníbal Limón
2015-11-09 22:01 ` Aníbal Limón [this message]
2015-11-09 22:01 ` [PATCH 03/10][AUH] recipe.py: Improvements and refactor of fetch method Aníbal Limón
2015-11-10  8:46   ` Paul Eggleton
2015-11-11 20:08     ` Aníbal Limón
2015-11-09 22:01 ` [PATCH 04/10][AUH] buildhistory.py: Don't modify BB_ENV_EXTRAWHITE before init Aníbal Limón
2015-11-10  8:54   ` Paul Eggleton
2015-11-11 20:14     ` Aníbal Limón
2015-11-09 22:01 ` [PATCH 05/10][AUH] upgradehelper.py: Add sanity test for ensure that git is configured Aníbal Limón
2015-11-10  8:59   ` Paul Eggleton
2015-11-11 20:15     ` Aníbal Limón
2015-11-09 22:01 ` [PATCH 06/10][AUH] buildhistory.py: Add missing warning import. git.py: Fix last_commit method Aníbal Limón
2015-11-09 22:01 ` [PATCH 07/10][AUH] upgradehelper.py: Improve work directory structure Aníbal Limón
2015-11-09 22:01 ` [PATCH 08/10][AUH] upgradehelper.py: Add support for do recipe upgrades based on builddep Aníbal Limón
2015-11-10  9:09   ` Paul Eggleton
2015-11-11 20:15     ` Aníbal Limón
2015-11-09 22:01 ` [PATCH 09/10][AUH] upgradehelper.py: Add support for preserve statistics into work directory Aníbal Limón
2015-11-09 22:01 ` [PATCH 10/10][AUH] requirements.txt: Add file for now only with GitPython Aníbal Limón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447106501-470-3-git-send-email-anibal.limon@linux.intel.com \
    --to=anibal.limon@linux.intel.com \
    --cc=paul.eggleton@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.