From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Pawelczyk Subject: Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments Date: Tue, 10 Nov 2015 11:15:02 +0100 Message-ID: <1447150502.2216.15.camel@samsung.com> References: <1444826525-9758-1-git-send-email-l.pawelczyk@samsung.com> <1444826525-9758-4-git-send-email-l.pawelczyk@samsung.com> <20151110041625.GA19875@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20151110041625.GA19875-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Al Viro Cc: Andy Lutomirski , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, NeilBrown , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Howells , Eric Dumazet , selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org, Eric Paris , Paul Moore , Jonathan Corbet , Lukasz Pawelczyk , Tetsuo Handa , Jiri Slaby , Calvin Owens , Stephen Smalley , Alexey Dobriyan , Kees Cook , Mauro Carvalho Chehab , Casey Schaufler , James Morris , Jann Horn , John Johansen , containers-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org, Greg Kroah-Hartman lin List-Id: containers.vger.kernel.org On wto, 2015-11-10 at 04:16 +0000, Al Viro wrote: > On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote: > > int (*getprocattr)(struct task_struct *p, char *name, char > > **value); > > - int (*setprocattr)(struct task_struct *p, char *name, void > > *value, > > - size_t size); > > + int (*setprocattr)(struct task_struct *p, const struct > > cred *f_cred, > > + char *name, void *value, size_t size); > > *grumble* > > Why the hell is that thing taking char *name - not even const char *? I was wondering that myself. But as this is unrelated I decided not to change it. Do you want me to while at it? -- From mboxrd@z Thu Jan 1 00:00:00 1970 Message-id: <1447150502.2216.15.camel@samsung.com> Subject: Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments From: Lukasz Pawelczyk To: Al Viro Cc: "David S. Miller" , "Eric W. Biederman" , "Serge E. Hallyn" , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Calvin Owens , Casey Schaufler , David Howells , Eric Dumazet , Eric Paris , Greg Kroah-Hartman , James Morris , Jann Horn , Jiri Slaby , Joe Perches , John Johansen , Jonathan Corbet , Kees Cook , Mauro Carvalho Chehab , NeilBrown , Paul Moore , Serge Hallyn , Stephen Smalley , Tejun Heo , Tetsuo Handa , containers@lists.linuxfoundation.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Lukasz Pawelczyk Date: Tue, 10 Nov 2015 11:15:02 +0100 In-reply-to: <20151110041625.GA19875@ZenIV.linux.org.uk> References: <1444826525-9758-1-git-send-email-l.pawelczyk@samsung.com> <1444826525-9758-4-git-send-email-l.pawelczyk@samsung.com> <20151110041625.GA19875@ZenIV.linux.org.uk> Content-type: text/plain; charset=UTF-8 MIME-version: 1.0 List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On wto, 2015-11-10 at 04:16 +0000, Al Viro wrote: > On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote: > > int (*getprocattr)(struct task_struct *p, char *name, char > > **value); > > - int (*setprocattr)(struct task_struct *p, char *name, void > > *value, > > - size_t size); > > + int (*setprocattr)(struct task_struct *p, const struct > > cred *f_cred, > > + char *name, void *value, size_t size); > > *grumble* > > Why the hell is that thing taking char *name - not even const char *? I was wondering that myself. But as this is unrelated I decided not to change it. Do you want me to while at it? -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Pawelczyk Subject: Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments Date: Tue, 10 Nov 2015 11:15:02 +0100 Message-ID: <1447150502.2216.15.camel@samsung.com> References: <1444826525-9758-1-git-send-email-l.pawelczyk@samsung.com> <1444826525-9758-4-git-send-email-l.pawelczyk@samsung.com> <20151110041625.GA19875@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andy Lutomirski , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, NeilBrown , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Howells , Eric Dumazet , selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org, Eric Paris , Paul Moore , Jonathan Corbet , Lukasz Pawelczyk , Tetsuo Handa , Jiri Slaby , Calvin Owens , Stephen Smalley , Alexey Dobriyan , Kees Cook , Mauro Carvalho Chehab , Casey Schaufler , James Morris , Jann Horn , John Johansen , containers-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org, Greg Kroah-Hartman , lin To: Al Viro Return-path: In-reply-to: <20151110041625.GA19875-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On wto, 2015-11-10 at 04:16 +0000, Al Viro wrote: > On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote: > > int (*getprocattr)(struct task_struct *p, char *name, char > > **value); > > - int (*setprocattr)(struct task_struct *p, char *name, void > > *value, > > - size_t size); > > + int (*setprocattr)(struct task_struct *p, const struct > > cred *f_cred, > > + char *name, void *value, size_t size); > > *grumble* > > Why the hell is that thing taking char *name - not even const char *? I was wondering that myself. But as this is unrelated I decided not to change it. Do you want me to while at it? --