All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S21 10/14] i40e: remove CONFIG_I40E_VXLAN
Date: Tue, 10 Nov 2015 18:04:52 +0000	[thread overview]
Message-ID: <1447178692.6967.7.camel@intel.com> (raw)
In-Reply-To: <1446852372-25480-11-git-send-email-joshua.a.hay@intel.com>

Hi,

On Fri, 2015-11-06 at 15:26 -0800, Joshua Hay wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> 
> Instead of having our own custom symbol, we can just rely
> on whether or not the kernel has the feature enabled.
> 
> In this case use IS_ENABLED(CONFIG_VXLAN) in order to handle
> built-in or module in the current BKM way.

The reason a separate symbol exists is for the case where CONFIG_I40E=y
(built in) and CONFIG_VXLAN=m (module). This causes issues if you don't
use the separate symbol because the VXLAN code won't load at kernel
load time, but the i40e module will try to find the symbol and fail.

You could either keep it and drop the menu config (default the value to
y) so that I40E_VXLAN is enabled as long as CONFIG_VXLAN is enabled, or
you could force VXLAN enabled for i40e permanently when i40e is
enabled.

Using CONFIG_VXLAN directly in code will only work if you never want to
support built-in compile of i40e, in which case you should force that
in Kconfig.

Regards,
Jake

  reply	other threads:[~2015-11-10 18:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 23:25 [Intel-wired-lan] [next PATCH S21 00/14] i40e/i40evf updates Joshua Hay
2015-11-06 23:25 ` [Intel-wired-lan] [next PATCH S21 01/14] i40evf: increase max number of queues Joshua Hay
2015-11-09 17:48   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 02/14] i40evf: set real num queues Joshua Hay
2015-11-09 18:02   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 03/14] i40evf: remove duplicate string Joshua Hay
2015-11-09 18:06   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 04/14] i40e: Detection and recovery of TX queue hung logic moved to service_task from tx_timeout Joshua Hay
2015-11-09 18:47   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 05/14] i40e: Fix memory leaks, sideband filter programming Joshua Hay
2015-11-09 19:02   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 06/14] i40evf: don't use atomic allocation Joshua Hay
2015-11-09 19:05   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 07/14] i40e: propagate properly Joshua Hay
2015-11-08 12:46   ` Jeff Kirsher
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 08/14] i40evf: use correct types Joshua Hay
2015-11-10 20:43   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 09/14] i40e: use priv flags to control packet split Joshua Hay
2015-11-10 20:48   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 10/14] i40e: remove CONFIG_I40E_VXLAN Joshua Hay
2015-11-10 18:04   ` Keller, Jacob E [this message]
2015-11-10 21:00   ` Bowers, AndrewX
2015-11-11  0:24   ` Singhai, Anjali
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 11/14] i40e: Remove separate functions gathering XOFF Rx stats Joshua Hay
2015-11-10 21:08   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 12/14] i40e: fix whitespace Joshua Hay
2015-11-10 21:09   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 13/14] i40e/i40evf: use logical operator Joshua Hay
2015-11-10 21:14   ` Bowers, AndrewX
2015-11-06 23:26 ` [Intel-wired-lan] [next PATCH S21 14/14] i40e/i40evf: Bump version to 1.4.7 for i40e and 1.4.3 for i40evf Joshua Hay
2015-11-10 21:15   ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447178692.6967.7.camel@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.