From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Cc: Robert Ho <robert.hu@intel.com>
Subject: Re: [OSSTEST PATCH 21/22] Serial: Factor out Osstest::Serial::keys_real
Date: Wed, 11 Nov 2015 10:12:33 +0000 [thread overview]
Message-ID: <1447236753.8556.33.camel@citrix.com> (raw)
In-Reply-To: <1447185214-6551-22-git-send-email-ian.jackson@eu.citrix.com>
On Tue, 2015-11-10 at 19:53 +0000, Ian Jackson wrote:
> The sympathy and xenuse serial modules had too much in common. Factor
> out the common code, which is now responsible for
> - knowledge of the Xen console switch
> - splitting strings up into individual keys
> - timing decisions
> - error trapping and logging
>
> This new class is an abstract base class for the concrete serial
> method classes, and calls back to its derived class to prepare, send
> each actual key, and shut down.
>
> There is some functional change: notably, after failure to send the
> first debug key, sending the remainder will not be attempted.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-11 10:12 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 19:53 [OSSTEST PATCH v16 00/22] Nested HVM Ian Jackson
2015-11-10 19:53 ` [OSSTEST PATCH 01/22] cs-adjust-flight: Add some missing doc comment info Ian Jackson
2015-11-11 9:45 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 02/22] cs-adjust-flight: Allow adjusting "this" flight Ian Jackson
2015-11-11 9:49 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 03/22] selecthost: Minor cleanups Ian Jackson
2015-11-11 9:51 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 04/22] selecthost: Support nested hosts (guests which are also hosts) Ian Jackson
2015-11-11 9:53 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 05/22] Nested hosts: Provide PDU power method Ian Jackson
2015-11-11 9:54 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 06/22] DhcpWatch::leases: Fix a reporting message Ian Jackson
2015-11-11 9:54 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 07/22] target_check_ip: Rename and improve from guest_check_ip Ian Jackson
2015-11-11 9:55 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 08/22] await_tcp(): Run check_ip on each loop iteration Ian Jackson
2015-11-11 9:55 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 09/22] LVM: Break out lv_create Ian Jackson
2015-11-11 9:58 ` Ian Campbell
2015-11-11 16:30 ` Ian Jackson
2015-11-11 16:40 ` Ian Campbell
2015-11-11 16:56 ` Ian Jackson
2015-11-10 19:53 ` [OSSTEST PATCH 10/22] Toolstack::xl: Provide block_attach method Ian Jackson
2015-11-11 9:58 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 11/22] sg-run-job: Break out per-host-prep and per-host-finish Ian Jackson
2015-11-11 10:00 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 12/22] sg-run-job: Provide infrastructure for layers of nesting Ian Jackson
2015-11-10 19:53 ` [OSSTEST PATCH 13/22] Nested HVM: Provide ts-nested-setup to help make L1 usable as a host Ian Jackson
2015-11-11 10:03 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 14/22] Nested HVM: Provide test-nested recipe Ian Jackson
2015-11-11 10:04 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 15/22] Nested HVM: Add test job to appropriate flights Ian Jackson
2015-11-11 10:07 ` Ian Campbell
2015-11-11 16:46 ` Ian Jackson
2015-11-10 19:53 ` [OSSTEST PATCH 16/22] ts-xen-install: Properly handle hosts without a static IP address Ian Jackson
2015-11-11 10:08 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 17/22] ts-xen-install: networking: Rename `nodhcp' to `ensurebridge' Ian Jackson
2015-11-11 10:08 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 18/22] Osstest/Testsupport.pm: change target's default kernkind to 'pvops' Ian Jackson
2015-11-11 10:09 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 19/22] Osstest/Testsupport.pm: use get_target_property() for some host setup Ian Jackson
2015-11-11 10:09 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 20/22] HVM guests: Use qemu "pipe:" for serial output logging Ian Jackson
2015-11-11 10:11 ` Ian Campbell
2015-11-10 19:53 ` [OSSTEST PATCH 21/22] Serial: Factor out Osstest::Serial::keys_real Ian Jackson
2015-11-11 10:12 ` Ian Campbell [this message]
2015-11-10 19:53 ` [OSSTEST PATCH 22/22] Serial: Add new serial method object for `guest' type Ian Jackson
2015-11-11 9:45 ` [OSSTEST PATCH v16 00/22] Nested HVM Ian Campbell
2015-11-11 10:18 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447236753.8556.33.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=robert.hu@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.