From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917AbbKKXCA (ORCPT ); Wed, 11 Nov 2015 18:02:00 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:55733 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbbKKXB7 (ORCPT ); Wed, 11 Nov 2015 18:01:59 -0500 From: Geert Uytterhoeven To: David Howells , Al Viro Cc: linux-cachefs@redhat.com, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() Date: Thu, 12 Nov 2015 00:02:01 +0100 Message-Id: <1447282921-16352-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fs/cachefiles/rdwr.c: In function ‘cachefiles_write_page’: fs/cachefiles/rdwr.c:882: warning: ‘ret’ may be used uninitialized in this function If the jump to label "error" is taken, "ret" will indeed be uninitialized, and random stack data may be printed by the debug code. Fixes: 102f4d900c9c8f5e ("FS-Cache: Handle a write to the page immediately beyond the EOF marker") Signed-off-by: Geert Uytterhoeven --- fs/cachefiles/rdwr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index 7a6b02f727874352..bdd28fe9a7f7195b 100644 --- a/fs/cachefiles/rdwr.c +++ b/fs/cachefiles/rdwr.c @@ -879,7 +879,7 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page) loff_t pos, eof; size_t len; void *data; - int ret; + int ret = 0; ASSERT(op != NULL); ASSERT(page != NULL); -- 1.9.1